Fix: store context in unctx and allow to not lose context on async calls with callWithContext #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've missed "wrapProperty" (and maybe some more) and will continue later. |
daniluk4000
changed the title
|
@danielroe can you take a look at this please? Without these changes our project would not go to Composables migration. I've published my own package in order to test this and my team to continue it's work and migration. This could be merged so those tens of thousands who use Nuxt CAPI will be able to not lose context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed main problem with useContext, but it works too well and I'm pretty sure I did this wrong (are SSR memory leaks possible here?).
Would like a deep review here. We'll try to already use this code in production by the way.