Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#356] Allow passing an array of ogImages #380

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FelixRe0
Copy link

I have dafted an idea, but I'm not sure why the additonal images are not added to the head.
Every element except the first has an unique hid added (hid + index position).

{ hid: 'og:image', name: 'og:image', property: 'og:image', content: 'https://example.org/image-standard.png' }, { hid: 'og:image:width', name: 'og:image:width', property: 'og:image:width', content: 1200 }, { hid: 'og:image:height', name: 'og:image:height', property: 'og:image:height', content: 630 }, { hid: 'og:image:type', name: 'og:image:type', property: 'og:image:type', content: 'image/png' }, { hid: 'og:image:1', name: 'og:image', property: 'og:image', content: 'https://example.org/image-square.png' }, { hid: 'og:image:width:1', name: 'og:image:width', property: 'og:image:width', content: 400 }, { hid: 'og:image:height:1', name: 'og:image:height', property: 'og:image:height', content: 400 }, { hid: 'og:image:type:1', name: 'og:image:type', property: 'og:image:type', content: 'image/png' }

=> They are added correctly to the meta array

Any ideas?

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #380 (e08e029) into main (3ebfd1a) will increase coverage by 0.11%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   84.67%   84.78%   +0.11%     
==========================================
  Files          12       12              
  Lines         398      401       +3     
  Branches      121      123       +2     
==========================================
+ Hits          337      340       +3     
  Misses         56       56              
  Partials        5        5              
Impacted Files Coverage Δ
lib/meta/module.js 79.00% <40.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebfd1a...e08e029. Read the comment docs.

Base automatically changed from master to main January 26, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant