Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get full scores on lighthouse we need to have the theme_color defined. At the moment it is set as undefined which means this will not be added to the head meta and therefore an error will show and you will not get full pwa score out of the box. Solution is to set the default color to white and allow users to modify it to another color if needed.
The theme color only works for android devices and setting it will not actually do anything on ios devices but not setting it will cause an error and will not give full pwa score
https://web.dev/themed-omnibox/?utm_source=lighthouse&utm_medium=devtools
Lighthouse 7 is soon to be released and there are major changes to pwa scoring but theme_color is still the only one that is failing so this will fix not only for Lighthouse 6 but also for Lighthouse 7
https://github.com/GoogleChrome/lighthouse/releases
cc @pi0