Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack bundler #3123

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

userquin
Copy link
Collaborator

@userquin userquin commented Sep 21, 2024

🔗 Linked issue

This PR disables optimizeTranslationDirective when using webpack and refactors the virtual logger to use unplugin:

imagen
error enabling optimizeTranslationDirective

Looks like we need something more to run it with webpack: userquin/nuxt-i18n-pwa-virtual#1

Virtual modules in webpack cannot have ::

imagen
error using virtual:nuxt-i18n-logger

imagen
error using ~nuxt-i18n/logger

/cc @danielroe there is no way, some hint 🙏 about virtuals in webpack?

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant