Replace @nuxthq/ui with @nuxt/ui in demo project
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update nuxt UI configuration and usage
❌ Deploy Preview for n3-supabase failed. Why did it fail? →
|
th1m0
suggested changes
Sep 1, 2024
demo/app.config.ts
Outdated
Comment on lines
2
to
4
| ui: { | ||
| primary: 'green', | ||
| } |
There was a problem hiding this comment.
Suggested change
| ui: { | |
| primary: 'green', | |
| } | |
| ui: { | |
| primary: 'green', | |
| }, |
demo/nuxt.config.ts
Outdated
Comment on lines
1
to
25
| export default defineNuxtConfig({ | ||
| modules: [ | ||
| // https://github.com/nuxt-modules/supabase | ||
| '@nuxtjs/supabase', | ||
| // UI lib (will be soon open sourced) | ||
| '@nuxthq/ui', | ||
| "@nuxtjs/supabase", | ||
| // https://github.com/nuxt/ui | ||
| "@nuxt/ui", | ||
| // https://github.com/nuxt-modules/color-mode | ||
| '@nuxtjs/color-mode', | ||
| "@nuxtjs/color-mode", | ||
| ], | ||
|
|
||
| runtimeConfig: { | ||
| public: { | ||
| baseUrl: process.env.BASE_URL || 'http://localhost:3000', | ||
| baseUrl: process.env.BASE_URL || "http://localhost:3000", | ||
| }, | ||
| }, | ||
| ui: { | ||
| colors: { | ||
| primary: 'green', | ||
| }, | ||
| icons: ['mdi', 'heroicons', 'heroicons-outline'], | ||
| }, | ||
|
|
||
| supabase: { | ||
| redirectOptions: { | ||
| login: '/', | ||
| callback: '/confirm', | ||
| login: "/", | ||
| callback: "/confirm", | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| compatibilityDate: "2024-09-01", | ||
| }); |
There was a problem hiding this comment.
Suggested change
| export default defineNuxtConfig({ | |
| modules: [ | |
| // https://github.com/nuxt-modules/supabase | |
| '@nuxtjs/supabase', | |
| // UI lib (will be soon open sourced) | |
| '@nuxthq/ui', | |
| "@nuxtjs/supabase", | |
| // https://github.com/nuxt/ui | |
| "@nuxt/ui", | |
| // https://github.com/nuxt-modules/color-mode | |
| '@nuxtjs/color-mode', | |
| "@nuxtjs/color-mode", | |
| ], | |
| runtimeConfig: { | |
| public: { | |
| baseUrl: process.env.BASE_URL || 'http://localhost:3000', | |
| baseUrl: process.env.BASE_URL || "http://localhost:3000", | |
| }, | |
| }, | |
| ui: { | |
| colors: { | |
| primary: 'green', | |
| }, | |
| icons: ['mdi', 'heroicons', 'heroicons-outline'], | |
| }, | |
| supabase: { | |
| redirectOptions: { | |
| login: '/', | |
| callback: '/confirm', | |
| login: "/", | |
| callback: "/confirm", | |
| }, | |
| }, | |
| }) | |
| compatibilityDate: "2024-09-01", | |
| }); | |
| export default defineNuxtConfig({ | |
| modules: [ | |
| // https://github.com/nuxt-modules/supabase | |
| '@nuxtjs/supabase', | |
| // https://github.com/nuxt/ui | |
| '@nuxt/ui', | |
| // https://github.com/nuxt-modules/color-mode | |
| '@nuxtjs/color-mode', | |
| ], | |
| runtimeConfig: { | |
| public: { | |
| baseUrl: process.env.BASE_URL || 'http://localhost:3000', | |
| }, | |
| }, | |
| supabase: { | |
| redirectOptions: { | |
| login: '/', | |
| callback: '/confirm', | |
| }, | |
| }, | |
| compatibilityDate: '2024-09-01', | |
| }) |
There was a problem hiding this comment.
Thanks for the review! Just now realized there's a linter in the root of the repo 🙈 fixed
pascalwengerter
commented
Sep 1, 2024
…monorepo root on demo app
th1m0
approved these changes
Sep 1, 2024
larbish
requested changes
Sep 2, 2024
There was a problem hiding this comment.
Thanks for the PR @pascalwengerter!
However I'm not able to start the demo locally (even after a clean of all deps and .nuxt folder). Are you not facing those issues with a fresh install?
Well it worked yesterday, starting the project today gives me the same error you displayed here -.- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
demo@nuxthq/uiwith@nuxt/uiindemoChecklist:
The updated Nuxt UI package is not a 100% replacement, but "good" enough - some margins/paddings have been changed, and the dark mode is not inversed on the cards anymore