BREAKING-CHANGE: Update stripe script. #509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gelanderosh is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
"Resolves #508 "
❓ Type of change:
📚 Description
This pull request updates the url and type of the exposed stripe instance by the composable, when i followed the guide to implement stripe with nuxt/scripts i detected typescript errors that shouldnt be there, the reason was that the previous versions of stripe's library used to expose the constructor as Stripe, however in the newer versions the type is called StripeConstructor.
The reason im marking it as a breaking change is the fact that stripes api has changed considerably with the newer version, and updating nuxt/scripts would automatically update the library which can cause implementation problems because of the deprecated functions and such.
If this being a breaking change is a problem i can also implement a different script for the newer version of stripe. and maintain the previous as legacy.