-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playwright): reuse existing server #881
Open
Barbapapazes
wants to merge
11
commits into
nuxt:main
Choose a base branch
from
Barbapapazes:feat/playwright/reuse-existing-server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(playwright): reuse existing server #881
Barbapapazes
wants to merge
11
commits into
nuxt:main
from
Barbapapazes:feat/playwright/reuse-existing-server
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
Barbapapazes
commented
Jul 2, 2024
This comment was marked as outdated.
This comment was marked as outdated.
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Jul 11, 2024
Hey 👋, @danielroe, I think this PR is ready for review. I put 2 todos inside the code that are more questions than todos. I'd like to hear what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #803
Hello 👋,
I was trying this module to write tests cause I really think tests are important.
But, in development, this module, e2e with Playwright, is slow. So slow that it creates too much friction to write tests and I think a lot of people will give up on writing tests because of that.
In the meantime, I use Playwright at work for e2e testing on an Angular app and it's fast. It's faster than unit tests with Jest and it's possible make test-first development with it.
After deep diving into the module, I found that for each test and each run a new app is built and started. This is the main reason for the slowness. While I understand this behavior on a CI pipeline, I don't think it's necessary on development. This is too much overhead for a little (or no) gain.
So I added a new option (similar to the existing one in Playwright, https://playwright.dev/docs/test-webserver#configuring-a-web-server) to reuse a dev server for all tests. This speeds up the tests a lot and makes it possible to use test-first development with Playwright.
While writing this, I realized that it could be possible to reuse the existing options instead of add a new one in the
use.nuxt
object. I'll try to do that in this PR. => this does not seems possible microsoft/playwright#7267Maybe we could just disable the Nuxt integration to be able to reuse existing options