Skip to content

Conversation

typed-sigterm
Copy link
Contributor

@typed-sigterm typed-sigterm commented Aug 15, 2025

πŸ”— Linked issue

close #4759

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As the title said

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Aug 15, 2025

npm i https://pkg.pr.new/@nuxt/ui@4760

commit: 00336b8

@J-Michalek
Copy link
Collaborator

We would also need to implement this to similar components such as Drawer and Slideover.

@typed-sigterm typed-sigterm changed the title feat(Modal): pass animating prop to slots feat(Modal): pass transitioning prop to slots Aug 16, 2025
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
@benjamincanac
Copy link
Member

Would you mind explaining why you need a transitioning slot prop? πŸ€”

@typed-sigterm
Copy link
Contributor Author

<UModal>
  <template #body="{ transitioning }">
    <UForm v-slot="{ loading }" @submit="submit">
      <UButton :loading="loading || transitioning" type="submit">Submit</button>
    </UForm>
  </template>
</UModal>

This prevents the submit button's loading state from disappearing before the modal closes.

@typed-sigterm typed-sigterm closed this by deleting the head repository Sep 5, 2025
@typed-sigterm
Copy link
Contributor Author

Oops, I forgot this PR and deleted the fork. Reopened at #4893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add transitioning to <Modal> slots prop
3 participants