Replace versionInfo references with buildVersion to restore compatibility with future versions of NVDA #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…26.1 no longer exposes these variables under versionInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the issue:
As of nvaccess/nvda#18682, the versionInfo module no longer re-exports version constants from BuildVersion. As a result, the update channel selector add-on fails to load on current NVDA alpha snapshots because those constants are no longer available via versionInfo.
Description of development approach:
This PR replaces all references to versionInfo with buildVersion. This works with both previous and future versions of NVDA because buildVersion has always been the original source of these constants. I did not modify buildVars.py to declare compatibility with NVDA 2026.1, as further API breaking changes may occur before the final release. Users can override compatibility if they wish to test this add-on with development snapshots.
Testing strategy:
I tested the add-on under NVDA 2025.3 and the latest alpha snapshot, verifying all functionality and confirming expected behavior in both environments
Known issues with this pull request:
None