curl: Fix response status parsing #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response headers can have multiple steps in them, example: "HTTP/1.1 200 Connection established", "", "HTTP/1.1 400 Bad Request", "Content-Security-Policy: default-src 'none'; sandbox", "Content-Type: text/plain; charset=utf-8", "Strict-Transport-Security: max-age=31536000", "X-Content-Type-Options: nosniff", before this would be reported as 200 incorrectly instead of 400 bad request. this fixes that issue Signed-off-by: Tomas Slusny <[email protected]>
deathbeam
force-pushed
the
curl-output
branch
from
46e7735 to
a5214d8
Compare
|
Hello, is there any chance this PR can be merged? |
|
@deathbeam @pidgeon777 @willnorris @dlee @rockerBOO Anybody still takes care of this? |
Collaborator
|
Thanks for the fix. sorry about everyone who got pinged. @unclenull managed to ping everyone who isnt maintaining the repository rather than the actual maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response headers can have multiple steps in them, example:
"HTTP/1.1 200 Connection established",
"",
"HTTP/1.1 400 Bad Request",
"Content-Security-Policy: default-src 'none'; sandbox", "Content-Type: text/plain; charset=utf-8",
"Strict-Transport-Security: max-age=31536000",
"X-Content-Type-Options: nosniff",
before this would be reported as 200 incorrectly instead of 400 bad request. this fixes that issue