Skip to content

fix: process all data on_output, even when not terminated with newline #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Conni2461 merged 2 commits into from
Jan 12, 2025
Merged

fix: process all data on_output, even when not terminated with newline #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f303c7c
fix: process all data on_output, even when not terminated with newline
msvechla Dec 13, 2024
cff2a07
test: activate pending tests related to newline stdin processing
msvechla Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/plenary/job.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ local on_output = function(self, result_key, cb)
cb(err, result_line, self)
end

if data == nil or is_complete then
if is_complete then
return
end

Expand Down
6 changes: 4 additions & 2 deletions tests/plenary/job_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe("Job", function()
assert.are.same(job:result(), results)
end)

pending("should split stdin across newlines with no ending newline", function()
it("should split stdin across newlines with no ending newline", function()
local results = {}
local job = Job:new {
-- writer = "hello\nword\nthis is\ntj",
Expand All @@ -113,6 +113,8 @@ describe("Job", function()
job:start()
job:send "hello\nwor"
job:send "ld"

wait_for_result(job, { "hello", "world" })
job:shutdown()

assert.are.same(job:result(), { "hello", "world" })
Expand All @@ -137,7 +139,7 @@ describe("Job", function()
assert.are.same(job:result(), results)
end)

pending("should return last line when there is no ending newline", function()
it("should return last line when there is no ending newline", function()
local results = {}
local job = Job:new {
command = "printf",
Expand Down