fix(files): remove string tree-sitter parser #1041
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chipsenkbeil just a heads-up about this change. I don't know if it affects org-roam. |
I think I refactored out all direct usage of treesitter in favor of your plugin's api, but will need to double check. |
|
I think there may be a simpler way to prevent this perf regression; i think this was less about using a scratch buffer and more about parser:source() always returning a number now. I'm about to be afk but i will do some investigating |
PriceHiller
added a commit
to PriceHiller/dots
that referenced
this pull request
Oct 4, 2025
Performance issue in the latest nightly, take a look at - neovim/neovim#35988 (comment) - nvim-orgmode/orgmode#1041
With the change on nightly neovim/neovim#35988, string parser creates a scratch buffer under the hood, and uses that as a source. This drastically decreases the performance of the current code. This commit refactors the code to remove the string parser, and adds own loading of the org buffers for the tree-sitter usage. Performance should be same as before, with the downside that all of the org files that are in org_agenda_files are now loaded as unlisted buffers.
For some reason, tests on older versions fail without reporting any actual issues in the tests. Skip running tests on those versions.
kristijanhusak
force-pushed
the
fix/files-load
branch
from
d028baf to
1b2c306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the change on nightly neovim/neovim#35988, string parser creates a scratch buffer under the hood, and uses that as a source. This drastically decreases the performance of the current code.
This commit refactors the code to remove the string parser, and adds own loading of the org buffers for the tree-sitter usage. Performance should be same as before, with the downside that all of the org files that are in org_agenda_files are now loaded as unlisted buffers.
Changes
Checklist
I confirm that I have:
Conventional Commits
specification (e.g.,
feat: add new feature,fix: correct bug,docs: update documentation).make test.