Skip to content

Initial changes to support extra configurable parameters and to print… #6237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nick1231321 wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Initial changes to support extra configurable parameters and to print… #6237

nick1231321 wants to merge 7 commits into from

Conversation

@nick1231321
Copy link

@nick1231321 nick1231321 commented Nov 26, 2025 •
edited by aniampio
Loading

This branch adds support for the additional configurable parameters introduced in
nicolas/sdk-param-support-debug in the nym vpn client branch and also debugging messages to verify that it works.

Ticket

JIRA-VPN-4558

Further details can be found in Configurable Mixnet Params – Design.

This change is Reviewable

@nick1231321 nick1231321 requested a review from aniampio November 26, 2025 13:02
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Thank you for making this first PR

@vercel
Copy link

vercel bot commented Dec 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nym-explorer-v2 Ready Ready Preview, Comment Dec 17, 2025 7:46pm
2 Skipped Deployments
Project Deployment Review Updated (UTC)
docs-nextra Ignored Ignored Preview Dec 17, 2025 7:46pm
nym-node-status Ignored Ignored Preview Dec 17, 2025 7:46pm

@aniampio aniampio requested a review from simonwicky December 3, 2025 12:49
simonwicky
simonwicky requested changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@simonwicky simonwicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, double check the changes you have in your PR. I usually do a soft reset to the latest develop to go through all of them. It will allow you to catch those line deletion for example.

For formatting, setup your IDE to format (I have format on save with rust-analyser on VSCode), we can help you with other setups if needed. If you don't want to/can't do that, run cargo fmt --all to format everything.

simonwicky
simonwicky requested changes Dec 4, 2025
View reviewed changes
@nick1231321 nick1231321 force-pushed the nicolas/sdk-param-support-debug branch from 42f63a0 to 8505458 Compare December 7, 2025 14:19
@nick1231321 nick1231321 force-pushed the nicolas/sdk-param-support-debug branch from 25ec91f to fa25986 Compare December 15, 2025 11:12
simonwicky
simonwicky requested changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@simonwicky simonwicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The open comments still holds

simonwicky
simonwicky approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@simonwicky simonwicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some duplicate log to remove and some empty lines that needs to stay there ;)
Once that's done, ship it.

Your call on the couple of nits

@simonwicky simonwicky marked this pull request as ready for review December 19, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonwicky simonwicky simonwicky approved these changes

@aniampio aniampio Awaiting requested review from aniampio

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Oscypek (est. mainnet 27.01.2026)

Development

Successfully merging this pull request may close these issues.

4 participants

@nick1231321 @aniampio @simonwicky