LP: mixnet reg fixes #6356
Open
LP: mixnet reg fixes #6356
+558
−533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
force-pushed
the
lp/mixnet-reg-x25519
branch
from
3325491 to
c862061
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
simonwicky
approved these changes
Jan 23, 2026
Contributor
simonwicky
left a comment
simonwicky
left a comment
There was a problem hiding this comment.
Non of these comments are blocking on that PR per se, but are points that I think should be addressed before the release
| pub use nym_registration_common::{ | ||
| LpGatewayData, LpRegistrationRequest, LpRegistrationResponse, RegistrationMode, | ||
| LpDvpnRegistrationRequest, LpMixnetGatewayData, LpMixnetRegistrationRequest, |
Contributor
There was a problem hiding this comment.
Why the re-export in the first place? It's used in a place where registration-common is already imported anyway
| inc!("lp_registration_dvpn_attempts"); | ||
|
|
||
| // Check for idempotent re-registration (same WG key already registered) | ||
| // This allows clients to retry registration after network failures |
Contributor
There was a problem hiding this comment.
It doesn't, at this point, LPDvpnRegistrationRequest already contains a credential.
A malicious could say "Oh you're already registered", keep the credential to create a double spending when the client tries to use the same credential somewhere else
jstuczyn
force-pushed
the
lp/mixnet-reg-x25519
branch
from
c862061 to
503904e
Compare
jstuczyn
force-pushed
the
lp/mixnet-reg-x25519
branch
from
503904e to
1b8fc4e
Compare
jstuczyn
force-pushed
the
lp/mixnet-reg-x25519
branch
from
1b8fc4e to
4edb60d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR does the following:
LpInputvariant to ignore the encodingThis change is