Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of zkApp deployments. #913

Merged
merged 14 commits into from
May 1, 2024
Merged

Review of zkApp deployments. #913

merged 14 commits into from
May 1, 2024

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Apr 27, 2024

Closes #461


Extended zkapp-cli output on zkApps deployment will be covered by the work on o1-labs/zkapp-cli#630

@shimkiv shimkiv self-assigned this Apr 27, 2024
@shimkiv shimkiv requested a review from a team as a code owner April 27, 2024 11:03
Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 0:32am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
07-oracles ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 0:32am

docs/zkapps/how-to-deploy-a-zkapp.mdx Show resolved Hide resolved
docs/zkapps/how-to-deploy-a-zkapp.mdx Show resolved Hide resolved
docs/zkapps/how-to-deploy-a-zkapp.mdx Show resolved Hide resolved
docs/zkapps/how-to-deploy-a-zkapp.mdx Outdated Show resolved Hide resolved
docs/zkapps/tutorials/03-deploying-to-a-network.mdx Outdated Show resolved Hide resolved
docs/zkapps/tutorials/03-deploying-to-a-network.mdx Outdated Show resolved Hide resolved
docs/zkapps/tutorials/03-deploying-to-a-network.mdx Outdated Show resolved Hide resolved
docs/zkapps/tutorials/03-deploying-to-a-network.mdx Outdated Show resolved Hide resolved
docs/zkapps/tutorials/03-deploying-to-a-network.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! I add some comments and suggestions that may warrant further discussion.

@shimkiv shimkiv requested a review from ymekuria April 30, 2024 11:48
Copy link
Contributor

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just had some minor comments.

docs/zkapps/how-to-deploy-a-zkapp.mdx Show resolved Hide resolved
docs/zkapps/how-to-deploy-a-zkapp.mdx Show resolved Hide resolved
docs/zkapps/tutorials/03-deploying-to-a-network.mdx Outdated Show resolved Hide resolved
@ymekuria ymekuria merged commit 4c1b041 into main May 1, 2024
4 checks passed
@ymekuria ymekuria deleted the review/zkapp-deploy branch May 1, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HF audit zkApp docs: How to Deploy a zkApp /zkapps/how-to-deploy-a-zkapp.mdx
3 participants