Skip to content

Unname some functor params that are not directly referred in the inte… - #917

Merged
glyh merged 1 commit into
masterfrom
lyh/do-not-name-unused-functor-params
Jan 22, 2026
Merged

Unname some functor params that are not directly referred in the inte…#917
glyh merged 1 commit into
masterfrom
lyh/do-not-name-unused-functor-params

Conversation

@glyh

@glyh glyh commented Jan 22, 2026

Copy link
Copy Markdown
Member

…rface

As title. This is motivated by o1js's side.

Running

nix run o1js#generate-bindings --max-jobs auto

On dw/bump-up-rust-nightly I got this error message:

> o1js@2.12.0 build:jsoo:node
> ./scripts/build/jsoo/build-node.sh

[jsoo-build-node] • building JSOO artifacts for node...
Checking if jemalloc is available... Yes, using jemalloc as an allocator
File "src/mina/src/lib/snarky/group_map/group_map.mli", line 36, characters 12-18:
36 |       end) (Params : sig
                 ^^^^^^
Error (warning 67 [unused-functor-parameter]): unused functor parameter Params.
File "src/mina/src/lib/snarky/src/base/utils.mli", line 22, characters 3-9:
22 |   (Runner : Runner.S
        ^^^^^^
Error (warning 67 [unused-functor-parameter]): unused functor parameter Runner.
File "src/mina/src/lib/mina_stdlib/bounded_types.ml", line 127, characters 2-42:
127 |   Bin_prot.Utils.Make_binable_without_uuid (struct
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Alert legacy: module Core_kernel.Bin_prot.Utils.Make_binable_without_uuid
Use [Make_binable_with_uuid] if possible.
File "src/mina/src/lib/mina_stdlib/bounded_types.ml", line 127, characters 2-42:
127 |   Bin_prot.Utils.Make_binable_without_uuid (struct
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Alert legacy: module Core_kernel.Bin_prot.Utils.Make_binable_without_uuid
Use [Make_binable_with_uuid] if possible.
[jsoo-build-node] ✖ JSOO build node failed (command: dune build ${TARGETS[@]/#/$JSOO_PATH/})
[build-o1js-node-artifacts.sh] ✖ Node artifacts build failed (command: npm run build:jsoo:node)
[update-o1js-bindings.sh] ✖ Update bindings failed (command: "$@")

@glyh
glyh merged commit 2c91275 into master Jan 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants