Add ErrorHandlerWithOpts
#15
Conversation
| type ErrorHandlerOpts struct { | ||
| *http.Request | ||
| *routers.Route | ||
| context.Context |
There was a problem hiding this comment.
Adding a field here error to capture the original error would be helpful (cf: #11 (comment))
There was a problem hiding this comment.
@MattiasMartens — Thank you for that suggested change. Assuming I understood your suggestion then I think it is an excellent idea. Actually, disappointed in myself for not thinking of it initially.
I made that change to the PR. Please review the PR to make sure I correctly understood what you were suggesting.
| if statusCode, route, err := validateRequest(r, router, options); err != nil { | ||
| if options != nil { | ||
| if options.ErrorHandlerWithOpts != nil { | ||
| options.ErrorHandlerWithOpts(w, err.Error(), statusCode, ErrorHandlerOpts{ |
There was a problem hiding this comment.
If change to ErrorHandlerOpts is implemented then we could add here:
| options.ErrorHandlerWithOpts(w, err.Error(), statusCode, ErrorHandlerOpts{ | |
| options.ErrorHandlerWithOpts(w, err.Error(), statusCode, ErrorHandlerOpts{ | |
| Error: err, |
There was a problem hiding this comment.
I made that change to the PR. Please review the PR to make sure I correctly understood what you were suggesting.
|
Thanks guys. Also looking for such functionality. |
This PR adds an alternate custom error handler with an additional
optsparameter that allows a custom error handler access to the incoming*http.Request, then matchedroutes.Route, and the relevantcontext.Context.My use-case for why the Route is needed is to be able to determine the appropriate Content-Type for an error response; should it be
application/json,text/htmlor something else?I added
Requestas I originally thought I would need it, but I didn't. Still, I can easily see that others might so it doesn't seem a harm to provide it.I added
Contextto explicitly fulfill the use-case for #13 & #14, and hopefully to supercede them.Lastly, I chose an
optsparameter passing inErrorHandlerOptsso that future needs could be accommodated easily by just adding a property without needing to add yet another signature and yet another type of error func.P.S. I also had to modify private function
validateRequest()to get it to return the matchedrouters.Route— as well as that that called it — given that access to theRoutewas the motivation for this PR.