Skip to content

Conversation

@kaja-osojnik
Copy link
Contributor

@kaja-osojnik kaja-osojnik commented Nov 11, 2025

Re-adding back mono fonts as updated on the designs and described in #2243

Closes #2243

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Deployed to Cloudflare Pages

Latest commit: f68bd09397910a938434a58f5fcde5d7a9863971
Status:✅ Deploy successful!
Preview URL: https://25fc4b9c.oasis-explorer.pages.dev
Alias: https://pr-2327.oasis-explorer.pages.dev

@kaja-osojnik kaja-osojnik force-pushed the kaja/reimplement-mono-fonts branch 11 times, most recently from 1292932 to 7d5332e Compare November 12, 2025 13:04
@kaja-osojnik kaja-osojnik marked this pull request as ready for review November 12, 2025 13:14
@buberdds
Copy link
Contributor

buberdds commented Nov 12, 2025

I have opened random URL and it seems like we need more work here:

  • rofl list -> App ID -> mono vs rofl details -> App ID - > Inter
  • rofl details replicas -> node id -> inter (should be mono looking at reqs)
  • replica details RAK -> mono REK-> inter (no consistency)
  • not sure what scope is, but I would extend it with Enclave ID and similar (but this can be adjusted in the future)
  • did not look at anything else, but I assume we need to scan entire app for mono use cases

@kaja-osojnik kaja-osojnik force-pushed the kaja/reimplement-mono-fonts branch 3 times, most recently from 339b1c5 to ddd92a4 Compare November 18, 2025 13:08
@kaja-osojnik
Copy link
Contributor Author

I have opened random URL and it seems like we need more work here:

  • rofl list -> App ID -> mono vs rofl details -> App ID - > Inter
  • rofl details replicas -> node id -> inter (should be mono looking at reqs)
  • replica details RAK -> mono REK-> inter (no consistency)
  • not sure what scope is, but I would extend it with Enclave ID and similar (but this can be adjusted in the future)
  • did not look at anything else, but I assume we need to scan entire app for mono use cases

@buberdds - replica RAK in table updated, everywhere else it looks like its like that in the design. Let me know if that needs to be changed in the design first.

@buberdds
Copy link
Contributor

I am not sure updating all possible views in Figma is what we need. If we have decided to use mono to render addresses or ids we should update all occurrences in code to meet requirements.

@kaja-osojnik
Copy link
Contributor Author

kaja-osojnik commented Nov 19, 2025

I am not sure updating all possible views in Figma is what we need. If we have decided to use mono to render addresses or ids we should update all occurrences in code to meet requirements.

@buberdds as discussed with @juresobocan - lets now leave it as in the design, and after we will work on creating a better system for where and how mono fonts are used across our projects.

@kaja-osojnik kaja-osojnik force-pushed the kaja/reimplement-mono-fonts branch 2 times, most recently from 55bc94c to 53ffcca Compare November 20, 2025 12:25
Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaja-osojnik , @juresobocan , I don't think designs are the "golden" truth here.

If we want to go forward with this, we need to make it consistent (even if designs are not) and make all occurrences of e.g. ROFL app ID, Node ID, RAK, REK, ...

Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to do this incrementally. If Kaja has to convert everything in one pullrequest we just risk more git conflicts

@kaja-osojnik kaja-osojnik force-pushed the kaja/reimplement-mono-fonts branch from 53ffcca to a172902 Compare November 21, 2025 11:28
@kaja-osojnik kaja-osojnik force-pushed the kaja/reimplement-mono-fonts branch from a172902 to 4e888db Compare November 24, 2025 14:33
@kaja-osojnik kaja-osojnik marked this pull request as draft November 24, 2025 14:35
@kaja-osojnik kaja-osojnik force-pushed the kaja/reimplement-mono-fonts branch 6 times, most recently from 97d53fe to 15340d5 Compare November 25, 2025 15:53
@kaja-osojnik kaja-osojnik marked this pull request as ready for review November 25, 2025 15:58
@kaja-osojnik kaja-osojnik marked this pull request as draft November 25, 2025 18:18
@kaja-osojnik kaja-osojnik force-pushed the kaja/reimplement-mono-fonts branch 4 times, most recently from 8b4f251 to f437537 Compare November 25, 2025 19:45
@kaja-osojnik kaja-osojnik marked this pull request as ready for review November 25, 2025 19:51
@lukaw3d lukaw3d force-pushed the kaja/reimplement-mono-fonts branch from 5bc573c to 7ca9485 Compare November 27, 2025 04:16
@lukaw3d
Copy link
Member

lukaw3d commented Nov 27, 2025

Rebased

@lukaw3d lukaw3d force-pushed the kaja/reimplement-mono-fonts branch from 7ca9485 to 5cafc8b Compare November 27, 2025 04:17
@lukaw3d lukaw3d requested a review from tjanez November 27, 2025 04:20
@lukaw3d
Copy link
Member

lukaw3d commented Dec 3, 2025

Blocked - I think Tadej/Jure want user interviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX]: Revisit and interview users about mono space vs sans font in Block Explorer

5 participants