-
Notifications
You must be signed in to change notification settings - Fork 12
Reimplement mono fonts #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Reimplement mono fonts #2327
Conversation
Deployed to Cloudflare Pages
|
1292932 to
7d5332e
Compare
|
I have opened random URL and it seems like we need more work here:
|
339b1c5 to
ddd92a4
Compare
@buberdds - replica RAK in table updated, everywhere else it looks like its like that in the design. Let me know if that needs to be changed in the design first. |
|
I am not sure updating all possible views in Figma is what we need. If we have decided to use mono to render addresses or ids we should update all occurrences in code to meet requirements. |
@buberdds as discussed with @juresobocan - lets now leave it as in the design, and after we will work on creating a better system for where and how mono fonts are used across our projects. |
55bc94c to
53ffcca
Compare
tjanez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaja-osojnik , @juresobocan , I don't think designs are the "golden" truth here.
If we want to go forward with this, we need to make it consistent (even if designs are not) and make all occurrences of e.g. ROFL app ID, Node ID, RAK, REK, ...
lukaw3d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to do this incrementally. If Kaja has to convert everything in one pullrequest we just risk more git conflicts
53ffcca to
a172902
Compare
a172902 to
4e888db
Compare
97d53fe to
15340d5
Compare
8b4f251 to
f437537
Compare
5bc573c to
7ca9485
Compare
|
Rebased |
7ca9485 to
5cafc8b
Compare
|
Blocked - I think Tadej/Jure want user interviews |
Re-adding back mono fonts as updated on the designs and described in #2243
Closes #2243