Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/2408.bugfix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support validators search by node or entity ids
9 changes: 9 additions & 0 deletions src/app/components/Search/search-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
isValidEthAddress,
isValidRoflAppId,
uniq,
isValidPublicKey,
} from '../../utils/helpers'
import { RouteUtils, SpecifiedPerEnabledLayer } from '../../utils/route-utils'
import { AppError, AppErrors } from '../../../types/errors'
Expand Down Expand Up @@ -214,6 +215,14 @@ export const validateAndNormalize = {

roflAppNameFragment: (searchTerm: string) => textSearch.roflAppName(searchTerm).result,

validatorEntityOrNodeId: (searchTerm: string) => {
const normalized = searchTerm.replace(/\s/g, '')

if (isValidPublicKey(normalized)) {
return normalized
}
},

evmAccount: (searchTerm: string): string | undefined => {
if (isValidEthAddress(`0x${searchTerm}`)) {
return `0x${searchTerm.toLowerCase()}`
Expand Down
2 changes: 1 addition & 1 deletion src/app/data/named-accounts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export type AccountNameSearchResults = {
isError: boolean
}

export type AccountNameSearchValidatorResults = {
export type ValidatorAccountSearchResults = {
results: Account[] | undefined
isLoading: boolean
isError: boolean
Expand Down
40 changes: 40 additions & 0 deletions src/app/hooks/useSearchForValidatorsByEntityOrNodeId.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import { useGetConsensusValidators, useGetConsensusAccountsAddresses } from 'oasis-nexus/api'
import { Network } from 'types/network'
import { ValidatorAccountSearchResults } from '../data/named-accounts'

export const useSearchForValidatorsByEntityOrNodeId = (
network: Network,
entityId?: string,
): ValidatorAccountSearchResults => {
const { isLoading, isError, data } = useGetConsensusValidators(
network,
{
id: entityId,
},
{
query: {
enabled: !!entityId,
},
},
)

const matches =
data?.data?.validators.map(validator => ({
address: validator.entity_address,
network,
})) || []

const {
isLoading: areConsensusAccountsLoading,
isError: areConsensusAccountsError,
data: consensusResults,
} = useGetConsensusAccountsAddresses(matches, {
enabled: !isLoading && !isError,
})

return {
isLoading: isLoading || areConsensusAccountsLoading,
isError: isError || areConsensusAccountsError,
results: consensusResults,
}
}
4 changes: 2 additions & 2 deletions src/app/hooks/useSearchForValidatorsByName.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
ValidatorAddressNameMap,
} from 'oasis-nexus/api'
import { Network } from 'types/network'
import { AccountNameSearchValidatorResults, AccountNameSearchConsensusMatch } from '../data/named-accounts'
import { ValidatorAccountSearchResults, AccountNameSearchConsensusMatch } from '../data/named-accounts'

function findAddressesWithMatch(
addressMap: ValidatorAddressNameMap,
Expand All @@ -26,7 +26,7 @@ function findAddressesWithMatch(
export const useSearchForValidatorsByName = (
network: Network,
nameFragment: string[],
): AccountNameSearchValidatorResults => {
): ValidatorAccountSearchResults => {
const { isLoading, isError, data } = useGetConsensusValidatorsAddressNameMap(network)
const matches =
data?.data && !!nameFragment.length ? findAddressesWithMatch(data?.data, nameFragment, network) : []
Expand Down
24 changes: 23 additions & 1 deletion src/app/pages/SearchResultsPage/hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { SearchParams } from '../../components/Search/search-utils'
import { SearchScope } from '../../../types/searchScope'
import { useSearchForAccountsByName } from '../../hooks/useAccountMetadata'
import { useSearchForValidatorsByName } from '../../hooks/useSearchForValidatorsByName'
import { useSearchForValidatorsByEntityOrNodeId } from '../../hooks/useSearchForValidatorsByEntityOrNodeId'

function isDefined<T>(item: T): item is NonNullable<T> {
return item != null
Expand Down Expand Up @@ -343,6 +344,22 @@ export function useNamedAccountConditionally(
}
}

export function useValidatorEntityOrNodeIdConditionally(id: string | undefined): ConditionalResults<Account> {
const queries = RouteUtils.getEnabledNetworksForLayer('consensus').map(network =>
// eslint-disable-next-line react-hooks/rules-of-hooks
useSearchForValidatorsByEntityOrNodeId(network, id),
)

return {
isLoading: queries.some(query => query.isLoading),
isError: queries.some(query => query.isError),
results: queries
.map(query => query.results)
.filter(isDefined)
.flat(),
}
}

export function useNamedValidatorConditionally(nameFragment: string[]) {
const queries = RouteUtils.getEnabledNetworksForLayer('consensus').map(network =>
// eslint-disable-next-line react-hooks/rules-of-hooks
Expand Down Expand Up @@ -415,6 +432,7 @@ export const useSearch = (currentScope: SearchScope | undefined, q: SearchParams
roflAppId: useRoflAppIdConditionally(q.roflAppId),
roflAppName: useRoflAppNameConditionally(q.roflAppNameFragment),
accountsByName: useNamedAccountConditionally(currentScope, q.accountNameFragment),
validatorByEntityId: useValidatorEntityOrNodeIdConditionally(q.validatorEntityOrNodeId),
validatorByName: useNamedValidatorConditionally(q.validatorNameFragment),
tokens: useRuntimeTokenConditionally(currentScope, q.evmTokenNameFragment),
proposals: useNetworkProposalsConditionally(q.networkProposalNameFragment),
Expand Down Expand Up @@ -443,7 +461,11 @@ export const useSearch = (currentScope: SearchScope | undefined, q: SearchParams
.filter(a => !alreadyAToken.has(a.network + a.layer + a.address)) // Deduplicate tokens
const roflApps = [...queries.roflAppId.results, ...queries.roflAppName.results]
const proposals = queries.proposals.results
const validators = [...queries.validatorByName.results, ...queries.oasisConsensusAccount.results]
const validators = [
...queries.validatorByName.results,
...queries.validatorByEntityId.results,
...queries.oasisConsensusAccount.results,
]
const results: SearchResultItem[] = isLoading
? []
: [
Expand Down
15 changes: 15 additions & 0 deletions src/app/utils/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,21 @@ export function getOasisAddressFromBase64PublicKey(key: string) {
return oasis.staking.addressToBech32(oasis.staking.addressFromPublicKey(keyBytes))
}

export const isValidPublicKey = (key: string): boolean => {
try {
const keyBytes = new Uint8Array(Buffer.from(key, 'base64'))

if (keyBytes.length !== 32) {
return false
}

const address = oasis.staking.addressFromPublicKey(keyBytes)
return !!address
} catch (e) {
return false
}
}

export const isValidTxOasisHash = (hash: string): boolean => /^[0-9a-fA-F]{64}$/.test(hash)

export const isValidTxEthHash = (hash: string): boolean => /^0x[0-9a-fA-F]{64}$/.test(hash)
Expand Down
6 changes: 6 additions & 0 deletions src/oasis-nexus/generated/api.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading