Skip to content

Introduce Oasis UI Library #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
csillag merged 4 commits into from
Jun 5, 2025
Merged

Introduce Oasis UI Library #252

csillag merged 4 commits into from
Jun 5, 2025

Conversation

@csillag
Copy link
Contributor

@csillag csillag commented May 22, 2025 •
edited
Loading

This PR introduces the UI library.

Done:

  • Add ui-library as a Git submodule
  • Add ui-library as a module dependency to several modules (home and wrap for a starter)
  • Iron out version incompatibilities (React etc)
  • Set up Tailwind CSS integration
  • Replace WrapButton with Button from the library everywhere in the Wrap component
  • Make sure that Wrap is still somewhat correctly styled

Not done:

  • Make sure the styling is perfect
  • Handle anything else but the buttons in Wrap
  • Fix the CI/CD (We can't pull the git submodule, since it's a private repo. Solution pending)

Current status:

image

@github-actions
Copy link

github-actions bot commented May 22, 2025 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: c29a37a2eded54b2a74361989a6ce41860c471c7
Status:✅ Deploy successful!
Preview URL: https://4f2a0726.rose-app.pages.dev
Alias: https://pr-252.rose-app.pages.dev

@csillag csillag changed the title [W.I.P.] Add Git submodule [W.I.P.] Add UI library (as a Git submodule) May 22, 2025
@csillag csillag force-pushed the csillag/add-ui-library branch 4 times, most recently from d8319b8 to 7eb79de Compare May 27, 2025 22:35
@csillag csillag changed the title [W.I.P.] Add UI library (as a Git submodule) Add UI library (as a Git submodule) May 27, 2025
@csillag csillag marked this pull request as ready for review May 27, 2025 22:53
lubej
lubej reviewed May 28, 2025
View reviewed changes
Copy link
Collaborator

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

@csillag csillag force-pushed the csillag/add-ui-library branch 3 times, most recently from e1c5d1e to 67ab9a0 Compare May 28, 2025 09:27
lubej
lubej reviewed May 28, 2025
View reviewed changes
Copy link
Collaborator

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just wait for @oasisprotocol/ui-library to be made public.

@csillag csillag force-pushed the csillag/add-ui-library branch from 67ab9a0 to 3da5c79 Compare May 28, 2025 10:17
lukaw3d
lukaw3d reviewed May 28, 2025
View reviewed changes
@csillag csillag force-pushed the csillag/add-ui-library branch 6 times, most recently from 77385e1 to d4b5986 Compare June 2, 2025 11:38
@csillag
Copy link
Contributor Author

csillag commented Jun 2, 2025

The CI issue with the private repo is now solved, however now we have a CI issue with praywright...

@csillag csillag force-pushed the csillag/add-ui-library branch from d4b5986 to 53609dd Compare June 2, 2025 11:46
@csillag
Copy link
Contributor Author

csillag commented Jun 2, 2025

Looks good, I would just wait for @oasisprotocol/ui-library to be made public.

It is now public, and all the tests are green.

@csillag csillag requested a review from lukaw3d June 2, 2025 12:09
tjanez
tjanez reviewed Jun 2, 2025
View reviewed changes
@lubej
Copy link
Collaborator

lubej commented Jun 3, 2025

Just noticing this, but looks like library styles messed up some styling. We should introduce release freeze, until we fully transform to the new UI library.

pr-252 rose-app pages dev_wrap_wrapper

@buberdds
Copy link
Contributor

buberdds commented Jun 3, 2025 •
edited
Loading

Shouldn't we include font integration here as well?

@lubej
Copy link
Collaborator

lubej commented Jun 3, 2025

Shouldn't we include font integration here as well?

Honestly it is not so much of a hustle to add it later, just by setting --default-font-family variable and including the fonts. Unless we have more than one, then it would be nice to add now.

@csillag csillag force-pushed the csillag/add-ui-library branch from 9656baf to 584b574 Compare June 3, 2025 14:55
@csillag csillag changed the title Add UI library (as a Git submodule) Introduce Oasis UI Library Jun 3, 2025
csillag added 3 commits June 3, 2025 16:57
@csillag
Add Git submodule and package dependency to UI
b967dc7
@csillag
Introduce ui-library
87dd4d6 
- Add @oasisprotocol/ui-library as a module dependency
  for "home" and "wrap" and modules
- Introduce a global.css to home, which is included
  in the main app, and imports the css from ui-library
- Apply the dark class, to enable
  the dark the from the ui-library
@csillag
Set up Tailwind CSS
ddcdf8e
@csillag csillag force-pushed the csillag/add-ui-library branch from 584b574 to ddcdf8e Compare June 3, 2025 14:57
@csillag
Copy link
Contributor Author

csillag commented Jun 3, 2025

So should we do something more with this (about fonts etc), or can we finally merge it?

buberdds
buberdds approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@buberdds buberdds left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo ci-lint will fail once we gonna add the first component due to checkout with missing submodules

@csillag csillag merged commit 40240a7 into master Jun 5, 2025
5 checks passed
@csillag csillag deleted the csillag/add-ui-library branch June 5, 2025 07:56
@csillag csillag mentioned this pull request Jun 5, 2025
Closed
@csillag
Copy link
Contributor Author

csillag commented Jun 5, 2025

imo ci-lint will fail once we gonna add the first component due to checkout with missing submodules

I thoughts so too, but ci-lint runs fine in #260 (where the Button component is imported to wrap), so apparently not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjanez tjanez tjanez left review comments

@buberdds buberdds buberdds approved these changes

@lubej lubej lubej approved these changes

@lukaw3d lukaw3d Awaiting requested review from lukaw3d lukaw3d is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csillag @lubej @buberdds @tjanez @lukaw3d