Fix/inf 452/vertical-writing first-line ruby fix moved to tao-core - #256
Open
olga-kulish wants to merge 2 commits into
Open
Fix/inf 452/vertical-writing first-line ruby fix moved to tao-core#256olga-kulish wants to merge 2 commits into
olga-kulish wants to merge 2 commits into
Conversation
📝 WalkthroughWalkthroughThe previewer layout SCSS receives declaration formatting updates, while vertical writing mode typography and custom text box spacing overrides are removed from both SCSS and compiled CSS. ChangesPreviewer styles
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Front-end summary Node 18
|
olga-kulish
marked this pull request as ready for review
July 30, 2026 11:05
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@views/js/previewer/provider/item/scss/inc/_previewer-layout.scss`:
- Around line 25-34: Reformat the multiline height calculation in the previewer
layout block so the multiplication operator is not followed by a newline,
keeping * at the end of the preceding line or restructuring the expression while
preserving the calculated height.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: https://raw.githubusercontent.com/oat-sa/tao-code-quality/main/coderabbit/php/authoring/v1/.coderabbit.yaml (via .coderabbit.yaml)
Review profile: CHILL
Plan: Pro
Run ID: ea4e0a2a-ba4c-44cd-a851-730faada319d
⛔ Files ignored due to path filters (1)
views/js/previewer/provider/item/css/item.css.mapis excluded by!**/*.map
📒 Files selected for processing (2)
views/js/previewer/provider/item/css/item.cssviews/js/previewer/provider/item/scss/inc/_previewer-layout.scss
olga-kulish
force-pushed
the
fix/INF-452/separator-between-columns
branch
from
July 30, 2026 12:20
51cb670 to
d8ba9f7
Compare
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
This was referenced Jul 30, 2026
Fix/inf 452/vertical-writing first-line ruby fix moved to tao-core
oat-sa/tao-test-runner-qti-fe#552
Open
olga-kulish
changed the title
oatymart
approved these changes
Jul 31, 2026
oatymart
left a comment
oatymart
left a comment
Member
There was a problem hiding this comment.
Looks fine, tested on unit01.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://oat-sa.atlassian.net/browse/INF-452
Item-runner related code moved to oat-sa/tao-core-ui-fe#712
All PRs: