Skip to content

feat: ruby placeholders update for ja-JP - #2814

Merged
KirylHatalski merged 1 commit into
developfrom
feat/AUT-4662/ruby-translations-placeholders
Jul 30, 2026
Merged

feat: ruby placeholders update for ja-JP#2814
KirylHatalski merged 1 commit into
developfrom
feat/AUT-4662/ruby-translations-placeholders

Conversation

@KirylHatalski

@KirylHatalski KirylHatalski commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

https://oat-sa.atlassian.net/browse/AUT-4662

Summary

  • Update ja-JP translations with ruby placeholders for furigana markup
  • Recompiled messages_po.js from updated messages.po

Related PRs

Summary by CodeRabbit

  • Localization
    • Updated Japanese translations across the interface, including testing, editing, exporting, validation, warnings, and reporting.
    • Improved wording for answer status, navigation, submission, time limits, review controls, import/export errors, and configuration warnings.
    • Added furigana support to selected Japanese messages for clearer readability.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

日本語の翻訳メッセージを、テスト作成・配信・レビュー・提出・インポート・エクスポート・検証関連の広範なUI文言で更新し、生成済みのJavaScript翻訳バンドルを再生成しました。

Changes

Japanese translation refresh

Layer / File(s) Summary
作成・設定・データ操作の翻訳
locales/ja-JP/messages.po
作成、設定、検証、識別子、ルーブリック、インポート、エクスポート、エラー関連の日本語訳を更新しました。
配信・レビュー・提出の翻訳
locales/ja-JP/messages.po, locales/ja-JP/messages_po.js
ナビゲーション、レビュー、未解答、時間制限、提出、オフライン状態、テスト完了関連の日本語訳と生成済み翻訳バンドルを更新しました。

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: ⏱️ 10-30 Min Review

Suggested reviewers: tikhanovicha, bartlomiejmarszal

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the ja-JP translation update and the addition of ruby placeholders.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/AUT-4662/ruby-translations-placeholders

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Version

Target Version 50.8.0
Last version 50.7.2

There are 0 BREAKING CHANGE, 1 feature, 0 fix

@github-actions

Copy link
Copy Markdown

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
822 822 0 0

@KirylHatalski
KirylHatalski marked this pull request as ready for review July 29, 2026 17:27
@KirylHatalski
KirylHatalski requested a review from a team as a code owner July 29, 2026 17:27

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 19

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@locales/ja-JP/messages.po`:
- Around line 929-930: Update the msgstr for “Missing filename for QTI Test
export” so the Japanese translation no longer contains misplaced quotation marks
and produces a natural, readable missing-filename error message.
- Around line 38-39: Update the translation for the message identified by “A
concurrent delivery has been detected...” to preserve the original recovery
workflow: use the last open session and close only the current window. Remove
the instructions to close all tabs and reopen the answer page, then regenerate
the locale bundle.
- Around line 1608-1609: Update the translation for the IMS QTI Test message so
it preserves “IMS” with the initial I and translates “Test” as a test rather
than an item. Keep the referenced placeholder and the rest of the diagnostic
meaning unchanged.
- Around line 128-129: Update the Japanese msgstr for “Allow the candidate to
review his answers.” to use grammatically natural wording for permitting the
candidate to review their answers, replacing the incorrect “解答のレビューする”
construction.
- Around line 1514-1515: Update the msgstr for “Test Saved” to a Japanese
confirmation indicating that the test was saved successfully, rather than the
imperative command “テストを保存”.
- Around line 518-519: Update the Japanese translation for “Enforce Item
Constraints” in messages.po to use terminology explicitly referring to item
constraints, distinct from the existing “Validate Responses” translation. Apply
the same correction to the duplicate entry referenced in the comment.
- Around line 1822-1823: Update the Japanese translation for the msgid “Upload a
QTI 2.1 Test Package File” so it explicitly refers to a test package, not a test
item, while preserving the existing upload and QTI 2.1 meaning.
- Around line 1690-1694: The Japanese translation for “The test has unsaved
changes, are you sure you want to leave?” incorrectly asks whether to save.
Update that msgstr to clearly ask whether the user wants to leave without
saving, while keeping the separate save-confirmation translation unchanged.
- Around line 1100-1101: Update the translation for the “Outcome” entry in the
messages catalog so it uses the Japanese term for the outcome itself, not the
existing term for “Outcome identifier.” Keep the separate identifier translation
unchanged.
- Around line 1481-1482: Update the Japanese translation for the “SUBMIT THIS
PART” msgid so it uses a clear submit-action label rather than “はい” (“Yes”);
leave unrelated message translations unchanged.
- Around line 1894-1895: Update the Japanese msgstr for the candidate-response
duration setting to explicitly refer to the test part’s configured maximum
duration, preserving the narrower scope expressed by the msgid rather than
referring to the entire test.
- Line 39: Add isolated automated tests for the Japanese translation entries,
including positive and negative cases that validate balanced ruby markup and
preserve %s/%d placeholders. Also add the planned ja-JP translation runner smoke
check, following the repository’s path-specific testing conventions.
- Around line 1714-1724: Update the Japanese translations for all four
unanswered-question messages, including the corresponding entries around the
additional referenced range, to preserve the %s placeholder in every string. Use
consistent question/item terminology rather than page terminology, while
retaining correct singular/plural distinctions and existing ruby markup.
- Around line 65-66: Update the translation for the message identified by msgid
“A valid response to this item is required.” so it requests a valid response
only for the current item, not all items. Preserve the existing Japanese ruby
markup while removing the wording that implies every item must be answered.
- Around line 1322-1323: Update the msgstr for the “Section Properties” entry to
use the Japanese terminology for “section” rather than “session,” while
preserving the intended “properties” meaning.
- Around line 1955-1962: Update the Japanese translations for the standalone
prompts “You are about to submit the test.” and “You are about to submit this
test part.” so they contain clear submission confirmation text instead of a
blank ideographic space. Correct the detailed prompt translation to refer to
submitting the test, not ending a question, while preserving its warning that
access is unavailable after submission and its OK confirmation instruction.
- Around line 338-339: Update the translation for msgid "Click \"%s\" to
continue." to retain the %s placeholder while preserving the existing Japanese
ruby markup and wording. Ensure the generated bundle also includes the
placeholder so the rendered prompt identifies the button.
- Around line 1560-1561: Update the msgstr for the assessment suspension message
to remove the malformed character sequence in “再度実施行して,” while preserving the
intended Japanese meaning and the rest of the translation.
- Around line 1517-1518: Update the msgstr for the “Test status” message in the
Japanese locale to use a translation meaning test status, not “question” or
“problem,” while keeping the msgid unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: https://raw.githubusercontent.com/oat-sa/tao-code-quality/main/coderabbit/php/authoring/v1/.coderabbit.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: c17c4eb4-0a5f-4bca-8bd2-b7c314dfb5ee

📥 Commits

Reviewing files that changed from the base of the PR and between 830a211 and f6127e8.

📒 Files selected for processing (2)
  • locales/ja-JP/messages.po
  • locales/ja-JP/messages_po.js

Comment thread locales/ja-JP/messages.po
Comment thread locales/ja-JP/messages.po
Comment thread locales/ja-JP/messages.po
Comment thread locales/ja-JP/messages.po
Comment thread locales/ja-JP/messages.po
Comment thread locales/ja-JP/messages.po
Comment thread locales/ja-JP/messages.po
Comment thread locales/ja-JP/messages.po
Comment thread locales/ja-JP/messages.po
Comment thread locales/ja-JP/messages.po
@KirylHatalski
KirylHatalski merged commit 5528e52 into develop Jul 30, 2026
6 checks passed
@KirylHatalski
KirylHatalski deleted the feat/AUT-4662/ruby-translations-placeholders branch July 30, 2026 11:11
@oat-github-bot oat-github-bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants