feat: ruby placeholders update for ja-JP - #2814
Merged
KirylHatalski merged 1 commit intoJul 30, 2026
Merged
Conversation
📝 WalkthroughWalkthrough日本語の翻訳メッセージを、テスト作成・配信・レビュー・提出・インポート・エクスポート・検証関連の広範なUI文言で更新し、生成済みのJavaScript翻訳バンドルを再生成しました。 ChangesJapanese translation refresh
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 29, 2026
Version
There are 0 BREAKING CHANGE, 1 feature, 0 fix |
Front-end summary Node 18
|
KirylHatalski
marked this pull request as ready for review
July 29, 2026 17:27
KirylHatalski
requested review from
Karol-Stelmaczonek,
bartlomiejmarszal,
pnal and
tikhanovichA
July 29, 2026 17:27
There was a problem hiding this comment.
Actionable comments posted: 19
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locales/ja-JP/messages.po`:
- Around line 929-930: Update the msgstr for “Missing filename for QTI Test
export” so the Japanese translation no longer contains misplaced quotation marks
and produces a natural, readable missing-filename error message.
- Around line 38-39: Update the translation for the message identified by “A
concurrent delivery has been detected...” to preserve the original recovery
workflow: use the last open session and close only the current window. Remove
the instructions to close all tabs and reopen the answer page, then regenerate
the locale bundle.
- Around line 1608-1609: Update the translation for the IMS QTI Test message so
it preserves “IMS” with the initial I and translates “Test” as a test rather
than an item. Keep the referenced placeholder and the rest of the diagnostic
meaning unchanged.
- Around line 128-129: Update the Japanese msgstr for “Allow the candidate to
review his answers.” to use grammatically natural wording for permitting the
candidate to review their answers, replacing the incorrect “解答のレビューする”
construction.
- Around line 1514-1515: Update the msgstr for “Test Saved” to a Japanese
confirmation indicating that the test was saved successfully, rather than the
imperative command “テストを保存”.
- Around line 518-519: Update the Japanese translation for “Enforce Item
Constraints” in messages.po to use terminology explicitly referring to item
constraints, distinct from the existing “Validate Responses” translation. Apply
the same correction to the duplicate entry referenced in the comment.
- Around line 1822-1823: Update the Japanese translation for the msgid “Upload a
QTI 2.1 Test Package File” so it explicitly refers to a test package, not a test
item, while preserving the existing upload and QTI 2.1 meaning.
- Around line 1690-1694: The Japanese translation for “The test has unsaved
changes, are you sure you want to leave?” incorrectly asks whether to save.
Update that msgstr to clearly ask whether the user wants to leave without
saving, while keeping the separate save-confirmation translation unchanged.
- Around line 1100-1101: Update the translation for the “Outcome” entry in the
messages catalog so it uses the Japanese term for the outcome itself, not the
existing term for “Outcome identifier.” Keep the separate identifier translation
unchanged.
- Around line 1481-1482: Update the Japanese translation for the “SUBMIT THIS
PART” msgid so it uses a clear submit-action label rather than “はい” (“Yes”);
leave unrelated message translations unchanged.
- Around line 1894-1895: Update the Japanese msgstr for the candidate-response
duration setting to explicitly refer to the test part’s configured maximum
duration, preserving the narrower scope expressed by the msgid rather than
referring to the entire test.
- Line 39: Add isolated automated tests for the Japanese translation entries,
including positive and negative cases that validate balanced ruby markup and
preserve %s/%d placeholders. Also add the planned ja-JP translation runner smoke
check, following the repository’s path-specific testing conventions.
- Around line 1714-1724: Update the Japanese translations for all four
unanswered-question messages, including the corresponding entries around the
additional referenced range, to preserve the %s placeholder in every string. Use
consistent question/item terminology rather than page terminology, while
retaining correct singular/plural distinctions and existing ruby markup.
- Around line 65-66: Update the translation for the message identified by msgid
“A valid response to this item is required.” so it requests a valid response
only for the current item, not all items. Preserve the existing Japanese ruby
markup while removing the wording that implies every item must be answered.
- Around line 1322-1323: Update the msgstr for the “Section Properties” entry to
use the Japanese terminology for “section” rather than “session,” while
preserving the intended “properties” meaning.
- Around line 1955-1962: Update the Japanese translations for the standalone
prompts “You are about to submit the test.” and “You are about to submit this
test part.” so they contain clear submission confirmation text instead of a
blank ideographic space. Correct the detailed prompt translation to refer to
submitting the test, not ending a question, while preserving its warning that
access is unavailable after submission and its OK confirmation instruction.
- Around line 338-339: Update the translation for msgid "Click \"%s\" to
continue." to retain the %s placeholder while preserving the existing Japanese
ruby markup and wording. Ensure the generated bundle also includes the
placeholder so the rendered prompt identifies the button.
- Around line 1560-1561: Update the msgstr for the assessment suspension message
to remove the malformed character sequence in “再度実施行して,” while preserving the
intended Japanese meaning and the rest of the translation.
- Around line 1517-1518: Update the msgstr for the “Test status” message in the
Japanese locale to use a translation meaning test status, not “question” or
“problem,” while keeping the msgid unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: https://raw.githubusercontent.com/oat-sa/tao-code-quality/main/coderabbit/php/authoring/v1/.coderabbit.yaml (via .coderabbit.yaml)
Review profile: CHILL
Plan: Pro
Run ID: c17c4eb4-0a5f-4bca-8bd2-b7c314dfb5ee
📒 Files selected for processing (2)
locales/ja-JP/messages.polocales/ja-JP/messages_po.js
bartlomiejmarszal
approved these changes
Jul 30, 2026
pnal
approved these changes
Jul 30, 2026
Karol-Stelmaczonek
approved these changes
Jul 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://oat-sa.atlassian.net/browse/AUT-4662
Summary
messages_po.jsfrom updatedmessages.poRelated PRs
Summary by CodeRabbit