WIP: Rk is backdrop modal widget impure validation haveibeenpwned#71
Closed
WIP: Rk is backdrop modal widget impure validation haveibeenpwned#71
Conversation
…nsystems/rhyolite into is-backdrop-modal-widget
this lets us set cookie that expire after the time indicated
…avoid confusing errors (when generated instances refer to things not in scope)
runObeliskRhyoliteWidget serves the purpose of making integration with Obelisk a little less hectic. standardPipeline serves as a useful example of what the final 'Pipeline' argument to serveDbOverWebsockets might look like.
…he older style functorial view selectors.
Collaborator
… in serveDbOverWebsockets.
…-backdrop-modal-widget-impure-validation-haveibeenpwned
3noch
reviewed
Jun 28, 2019
| { | ||
| "owner": "bgamari", | ||
| "repo": "monoidal-containers", | ||
| "branch": "master", |
Collaborator
There was a problem hiding this comment.
Might want to use my PR on this instead since it has some more fixes.
Collaborator
Author
There was a problem hiding this comment.
oh, interesting
We're just shaving another yak right now actually, I should change the branch perhaps on my actual update branch, rather than this hasty merge of that and the branch we're using on interos... and/or I should review everything that's gone on here, and pull in the other direction.
Collaborator
There was a problem hiding this comment.
This PR is all but merged by Ben: bgamari/monoidal-containers#41
Member
|
Please update the changelog. |
Collaborator
Author
|
Ah, sorry! I didn't mean to edit this PR. I merged my other stuff into it so that we can attempt to update a client project. |
Collaborator
Author
|
I'll sort it out in a minute. |
cgibbard
changed the title
ali-abrar
deleted the
rk-is-backdrop-modal-widget-impure-validation-haveibeenpwned
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some stuff that was in @eskimor 's repo