Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log fatal CEF crashes to file #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WizardCM
Copy link
Member

@WizardCM WizardCM commented Nov 2, 2024

Description

CEF provides no method to reroute logging, but without FATAL logging it is impossible to track down some crashes.

This outputs FATAL-level logging to debug.log in the obs-browser user data directory.

Motivation and Context

We don't ship CEF symbols so some crashes become impossible to track down. By logging fatal errors, we can get some insight.

How Has This Been Tested?

Launched OBS on Windows. Verified the debug.log contained an error after a crash.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

CEF provides no method to reroute logging, but without FATAL logging
it is impossible to track down some crashes.
@WizardCM WizardCM added the Enhancement New feature or improvement label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants