Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin template repository with code changes from obs-studio repository #126

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PatTheMav
Copy link
Member

Description

Updates CI, CMake, and build scripts to port over changes made by/for the obs-studio repo.

Changes include:

  • Switch from cmake-format to gersemi as code-formatting tool for CMake files
  • Split up macOS and Linux build scripts to allow more independent adaptation to Linux requirements
  • Made macOS build scripts CI only (just like on obs-studio)
  • Removed aarch64 toolchains and preset support for Linux (due to lack of obs-studio compatibility)
  • Made Windows build scripts CI only (just like on obs-studio)
  • Updated dependency hashes

Fixes #123.
Fixes #124.
Fixes #116.

Motivation and Context

Plugin template repository should be regularly updated to stay in sync with developments that occurred on obs-studio.

How Has This Been Tested?

Local builds successfully tested on macOS 14, CI changes require CI runs to test.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@PatTheMav
Copy link
Member Author

Requires obsproject/obs-studio#11114 to be merged and the OBS tag/release to be updated for the plugintemplate.

@RytoEX
Copy link
Member

RytoEX commented Aug 20, 2024

Requires obsproject/obs-studio#11114 to be merged and the OBS tag/release to be updated for the plugintemplate.

The obs-studio PR has been merged, but there is no new tag/release yet.

Would it be possible to get an intermediate update for 30.2.x in the mean time?

@PatTheMav
Copy link
Member Author

Requires obsproject/obs-studio#11114 to be merged and the OBS tag/release to be updated for the plugintemplate.

The obs-studio PR has been merged, but there is no new tag/release yet.

Would it be possible to get an intermediate update for 30.2.x in the mean time?

For the plugintemplate you mean?

@RytoEX
Copy link
Member

RytoEX commented Aug 20, 2024

Requires obsproject/obs-studio#11114 to be merged and the OBS tag/release to be updated for the plugintemplate.

The obs-studio PR has been merged, but there is no new tag/release yet.
Would it be possible to get an intermediate update for 30.2.x in the mean time?

For the plugintemplate you mean?

Yes.

@PatTheMav
Copy link
Member Author

Requires obsproject/obs-studio#11114 to be merged and the OBS tag/release to be updated for the plugintemplate.

The obs-studio PR has been merged, but there is no new tag/release yet.
Would it be possible to get an intermediate update for 30.2.x in the mean time?

For the plugintemplate you mean?

Yes.

I'd have to check, wholly depends on whether the legacy path on Windows generates the libraries the way the update needs them to, can check that later.

@RytoEX
Copy link
Member

RytoEX commented Aug 20, 2024

I'd have to check, wholly depends on whether the legacy path on Windows generates the libraries the way the update needs them to, can check that later.

I mostly just mean would it make sense to update buildspec for 30.2.x in the meantime, or are there other changes required?

@PatTheMav
Copy link
Member Author

I'd have to check, wholly depends on whether the legacy path on Windows generates the libraries the way the update needs them to, can check that later.

I mostly just mean would it make sense to update buildspec for 30.2.x in the meantime, or are there other changes required?

In that case I'd let a different PR take care of that, because this PR is much larger in scope.

@RytoEX
Copy link
Member

RytoEX commented Aug 21, 2024

In that case I'd let a different PR take care of that, because this PR is much larger in scope.

Yes, that's what I was suggesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants