Adapt JSOO rules for new --effects= option

[OlivierNicole]

This takes into account the new js_of_ocaml --effects={cps,double-translation} flag, introduced in ocsigen/js_of_ocaml#1461.

[OlivierNicole]

Note: I have used failwith when a dune rule is asking to pass --effects=double-translation with a version of jsoo/wasmoo that doesn’t support it, because I don’t know what the proper way of erroring in this code path is.

[vouillon]

Note: I have used failwith when a dune rule is asking to pass --effects=double-translation with a version of jsoo/wasmoo that doesn’t support it, because I don’t know what the proper way of erroring in this code path is.

I think you can just use --enable=effects in that case, and let the invocations of js_of_ocaml --effects=double-translation fail.

[OlivierNicole]

I’m not sure to understand where the last CI failure comes from.

[OlivierNicole]

Thank you for your reviews, I think I have addressed the ones made up to now.

[hhugo]

I think you should add some tests that you would run manually now and that would run in the CI once jsoo.6.0 is released.

I've tested this PR manually and it doesn't quite work because the --effects flags is sometime repeated (which is treated as an error by jsoo)

[OlivierNicole]

Can you share how you encountered the bug?

[hhugo]

I've just tried to use this PR to run test in jsoo. Same behavior in https://github.com/ocsigen/js_of_ocaml/actions/runs/13032240200/job/36353967506?pr=1821

[OlivierNicole]

I think it should be fixed now.

I will look at adding tests, should they be in this PR?

[OlivierNicole]

I have added a test but for it to work, it would require to use JSOO 6.0.1 in CI.

The other failures seem unrelated to this PR.

[OlivierNicole]

I have added a test but for it to work, it would require to use JSOO 6.0.1 in CI.

Oh in fact, it’s already the case.

[hhugo]

I don't really like the current situation but it's not the fault of this PR. Sadly I don't have time to spend on this right now. @vouillon would you have time to review this and approve if it's ok.

[hhugo]

@OlivierNicole, @vouillon we should probably try to have this part of the next 3.18 release.

[vouillon]

I don't really like the current situation but it's not the fault of this PR. Sadly I don't have time to spend on this right now. @vouillon would you have time to review this and approve if it's ok.

I'm not really happy with that either. Each time we add some options in js_of_ocaml/wasm_of_ocaml, we need to update Dune as well. But I think this is ok for now.

[hhugo]

@OlivierNicole, can you rebase the PR ? hoping it will fix the CI

[hhugo]

ping @OlivierNicole

[OlivierNicole]

@hhugo Sorry for the delay; I have rebased.

[rgrinberg]

@hhugo or @vouillon is this good to go?

[hhugo]

@hhugo or @vouillon is this good to go?

I think so

[hhugo]

I'm testing it in ocsigen/js_of_ocaml#1957

[hhugo]

good to merge