Skip to content

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Oct 15, 2025

We add 3 new dev shells for OxCaml:

  • bootstrap-ox: For testing the bootstrap process with OxCaml
  • ox-minimal: For building dune with OxCaml and running the OxCaml test-cases
  • ox: For attempting to build a dev shell with OxCaml

In order to do this, we need to fetch the latest patches from the OxCaml opam repo, however not all of them can be applied to the package versions found in nixpkgs. Because of this we cannot build a full devShell, but we can get pretty close. The File nix/ox-patches.nix deals with the fetching and application of the patches.

Tldr: This works:

nix develop .#ox-minimal -c dune runtest test/blackbox-tests/test-cases/oxcaml

@Alizter Alizter requested a review from rgrinberg October 15, 2025 20:05
@Alizter Alizter marked this pull request as ready for review October 16, 2025 08:40
Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked closely as my nix is fairly weak, but if it works then that's enough for me. Having these checks in CI would be amazingly useful of course. That could be done in a subsequent PR.

cc @anmonteiro just so he's aware of this.

Feel free to proceed with this PR anyhow.

We add 3 new dev shells for OxCaml:

- bootstrap-ox: For testing the bootstrap process with OxCaml
- ox-minimal: For building dune with OxCaml and running the OxCaml test-cases
- ox: For attempting to build a dev shell with OxCaml

In order to do this, we need to fetch the latest patches from the OxCaml
opam repo, however not all of them can be applied to the package
versions found in nixpkgs. Because of this we cannot build a full
devShell, but we can get pretty close. The File nix/ox-patches.nix deals
with the fetching and application of the patches.

Signed-off-by: Ali Caglayan <[email protected]>
@Alizter Alizter enabled auto-merge October 22, 2025 07:07
@Alizter Alizter merged commit 515f403 into ocaml:main Oct 22, 2025
26 checks passed
@Alizter Alizter deleted the push-uzvznuxnmqnl branch October 22, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants