Dune Pins itself #12583
Merged
Dune Pins itself #12583
+171
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
fix-12381
branch
2 times, most recently
from
c67cc3b to
6ab69e5
Compare
Signed-off-by: Rudi Grinberg <[email protected]>
The version of dune inside the opam repo is overriding the version of dune that is being used. That seems wrong. At least most of the time. Signed-off-by: Rudi Grinberg <[email protected]>
Fuse it with [git_repo] since that is the only place where it's needed Signed-off-by: Rudi Grinberg <[email protected]>
Automatically make dune pin itself. We're going to assume that the dune we're using right now is the one that will be used to run the build plan. Perhaps this behavior isn't always deired. We could imagine wanting to produce build plans for older or newer dunes. For now, this is a good default though. Addresses #12381 Signed-off-by: Rudi Grinberg <[email protected]>
gridbugs
reviewed
Oct 20, 2025
test/blackbox-tests/test-cases/pkg/unsatisfied-version-constraint-on-dune.t
Show resolved
Hide resolved
gridbugs
approved these changes
Oct 20, 2025
|
The dev commit will go away when I squash |
Alizter
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the commit that fixes the issue:
Automatically make dune pin itself. We're going to assume that the dune
we're using right now is the one that will be used to run the build
plan.
Perhaps this behavior isn't always deired. We could imagine wanting to
produce build plans for older or newer dunes. For now, this is a good
default though.
A separate commit is made for a small preliminary refactoring to ease reviewing.
Fixes #12381