[3.32.1 backport] fix: include sys/wait.h on NetBSD in lev_stubs.c (#14512)#14526
Merged
Merged
Conversation
Fixes ocaml#14484. NetBSD needs the same `<sys/wait.h>` include as FreeBSD and OpenBSD so that the `WIFEXITED`, `WEXITSTATUS`, `WIFSTOPPED`, `WSTOPSIG` and `WTERMSIG` macros are available when building `lev_stubs.c`. Without it the bootstrap fails at link time on NetBSD with undefined references to these symbols. ``` ld: /home/runner/work/dune/dune/_boot/src/lev/src/lev_stubs.c:515: undefined reference to `WIFEXITED' ld: …:517: undefined reference to `WEXITSTATUS' ld: …:518: undefined reference to `WIFSTOPPED' ld: …:525: undefined reference to `WTERMSIG' ld: …:521: undefined reference to `WSTOPSIG' Error: Error during linking (exit code 1) ``` Failing CI run (before the fix): https://github.com/Alizter/dune/actions/runs/25815321578/job/75842142913?pr=9#step:3:403 Passing NetBSD x86-64 job on this PR (with the fix): https://github.com/ocaml/dune/actions/runs/25816678888/job/75846908855 Patch suggested by @0-wiz-0 in ocaml#14484. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
netbsd-fix-backport
branch
from
e1102aa to
9ac53a7
Compare
20 tasks
Member
|
There seem to be new CI failures here that persist on rebuilds. Do we know what's up with that? |
Collaborator
|
Not relevant for this change AFAIK #14527 |
Member
|
Got it. Thanks! |
shonfeder
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14512 onto 3.32.1