fix(cram): show partial output on timeout - #15269
Merged
Merged
Conversation
rgrinberg
force-pushed
the
push-ykwlsomsnsuw
branch
from
June 21, 2026 14:23
be8c1e7 to
87e1a43
Compare
Alizter
reviewed
Jun 22, 2026
| $ cat > dune <<EOF | ||
| > (cram | ||
| > (timeout 0.1)) | ||
| > (timeout 0.5)) |
Collaborator
There was a problem hiding this comment.
Why bump the timeout? Won't this make the test slow?
Member
Author
There was a problem hiding this comment.
Because we need to give this enough time to print some output so that the test doesn't flake.
Collaborator
There was a problem hiding this comment.
Could you do this with an external FIFO or something?
Member
Author
There was a problem hiding this comment.
There's still a reliance on dune's internal timer firing at a certain point.
rgrinberg
force-pushed
the
push-ykwlsomsnsuw
branch
6 times, most recently
from
June 27, 2026 15:05
452b50f to
ff50790
Compare
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> refactor(cram): simplify timeout output handling Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-ykwlsomsnsuw
branch
from
June 27, 2026 16:38
ff50790 to
f2bb826
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cram tests time out, it's helpful to see the partial output emitted so far instead of an error message. This PR accomplishes that.