Skip to content

refactor(watch): remove build request callback indirection #15348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrinberg merged 1 commit into from
Jun 26, 2026
+1 −4
Merged

refactor(watch): remove build request callback indirection #15348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/dune_engine/build_loop.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ let run_current_build
~run_id
~finish_when_rpc_requests_finished
~request
run_build
=
let* () = reset_wakeup t in
(match t.status with
Expand All @@ -255,7 +254,7 @@ let run_current_build
~run_id
~cancellation:(Fiber.Cancel.create ())
in
run_build ?restart_started_at ~build:build_ctx ())
Build_system.run_build_requests ?restart_started_at ~build:build_ctx request)
~finally:(fun () ->
t.current_request <- None;
Fiber.return ())
Expand Down Expand Up @@ -394,8 +393,6 @@ let rpc_poll_iter t ~action_runner ~sticky_goal ~sticky_built_at =
~run_id
~finish_when_rpc_requests_finished
~request
(fun ?restart_started_at ~build () ->
Build_system.run_build_requests ?restart_started_at ~build request)
in
(match next with
| `Restart -> loop ()
Expand Down
Loading