Improving the readability of signature_help for long signatures #1580
+142
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucccyo
force-pushed
the
sig_help_bad_readability
branch
from
56f1940 to
326091b
Compare
Author
|
@voodoos, let's open the discussion on whether the format is added at the right moment. |
Lucccyo
force-pushed
the
sig_help_bad_readability
branch
2 times, most recently
from
c886ecd to
1ec1dc2
Compare
Author
|
@voodoos, what were your ideas for managing the shift in the offsets ? |
Collaborator
|
I think we should first try the naive option: roughly parse the resulting string, accumulating the offsets of the parameters we found ? They should be separated by |
Lucccyo
force-pushed
the
sig_help_bad_readability
branch
from
1ec1dc2 to
4c7592d
Compare
Author
|
Why should we ignore labels ? |
Collaborator
Looking at the current behavior: you are right, we don't :-) |
Lucccyo
force-pushed
the
sig_help_bad_readability
branch
from
4c7592d to
6262de2
Compare
Lucccyo
force-pushed
the
sig_help_bad_readability
branch
2 times, most recently
from
2aeaece to
fce35f2
Compare
voodoos
reviewed
Jan 30, 2026
Lucccyo
force-pushed
the
sig_help_bad_readability
branch
from
fce35f2 to
153a23c
Compare
voodoos
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the readability of the signature of signature_help.
It applies now
ocamlformatto the signature.