Destruct custom request #1583
Merged
Destruct custom request #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvw
force-pushed
the
destruct-code-action
branch
from
e13b017 to
4f7e3c8
Compare
Co-authored-by: Ulysse <[email protected]>
Co-authored-by: Ulysse <[email protected]>
Co-authored-by: Ulysse <[email protected]>
Collaborator
|
Thanks ! |
voodoos
reviewed
Jan 28, 2026
CHANGES.md
Outdated
| - Add `typeExpression` custom request (#1576) | ||
| - Add `locate` custom request (#1576) | ||
| - Add `phrase` custom request (#1576) | ||
| - Add `destruct` custom request (#1583) |
Collaborator
There was a problem hiding this comment.
Ah ! But 1.25.0 was released already, we need a new changelog section :-)
Next time we should add the section right after the release...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
ocaml-eglot, it make sense to relay on a custom request instead of a code action for punctually trigger the command.