Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] tcpip (7.1.2) #21897

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

dinosaure
Copy link
Contributor

OCaml TCP/IP networking stack, used in MirageOS

CHANGES:

CHANGES:

* TCP: fix memory leaks on connection close in three scenarios (mirage/mirage-tcpip#489 @TheLortex)
  - simultanous close: set up the timewait timer in the `Closing(1) - Recv_ack(2) -> Time_wait`
    state transition
  - client sends a RST instead of a FIN: enable sending a challenge ACK even when the reception
    thread is stopped
  - client doesn't ACK server's FIN: enable the retransmit timer in the `Closing(_)` state
@TheLortex
Copy link
Contributor

There is a single failure for MacOS tests: is there something to do about it ?

@samoht
Copy link
Member

samoht commented Jul 28, 2022

#   [FAIL]        socket                      0   two sockets connect via TCP.
#   [SKIP]        socket                      1   icmp echo-requests are sent.
#   [FAIL]        socket                      2   file descriptors are not leak...

It would be nice to check these are not actual errors.

@hannesm
Copy link
Member

hannesm commented Jul 28, 2022

since it is the socket stack, I doubt the changes from 7.1.1..7.1.2 are related. I also remember that some of these tests were sometimes failing on macos. IMHO good to merge. if you've a mac and some time, please investigate what the issue is.

@kit-ty-kate
Copy link
Member

Thanks

@kit-ty-kate kit-ty-kate merged commit 29e03ee into ocaml:master Jul 28, 2022
@dinosaure dinosaure deleted the release-tcpip-v7.1.2 branch July 28, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants