Skip to content

Conversation

maiste
Copy link
Contributor

@maiste maiste commented Sep 3, 2025

Fast, portable, and opinionated build system

CHANGES:

Fixed

CHANGES:

### Fixed

- Fix jsoo separate compilation with modules_without_implementation. Regression
  introduced in ocaml/dune#10767. (ocaml/dune#12320, fixes ocaml/dune#12306 @hhugo)

- Fix `runtest-js` mistakenly using wrong dependencies (ocaml/dune#12324, @vouillon)

- Remove empty `.cram.test.t` directory during the running of a cram test.
  (ocaml/dune#12329, fixes ocaml/dune#12321, @Alizter)

- Fix Cygwin bootstrap (ocaml/dune#12325, fixes ocaml/dune#12316, @Alizter)
@maiste maiste mentioned this pull request Sep 3, 2025
10 tasks
@raphael-proust
Copy link
Contributor

@maiste let us know when you've had time to look at the CI results. I can't see anything that's noteworthy, but i have low confidence i would even see the signal if there was some because of the amount of noise.

@maiste
Copy link
Contributor Author

maiste commented Sep 4, 2025

Thanks @raphael-proust for having taken a quick look. I had a look this morning and the CI seemed to be still running. Now, it seems to have been restarted. I'll take a look tomorrow morning, it should be done. I'll ping you once it is done 👍🏻

@maiste
Copy link
Contributor Author

maiste commented Sep 5, 2025

@raphael-proust, comparing the outputs, it seems coherent with what we had for 3.20.1. The only two concerning errors I have are from gdbprofiler and opam-check-npm-deps but the errors seem to come from a type error, not from dune.

@Alizter, does it seem good to you too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants