Make sure n_steps_default >= 3
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangrooms
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Our current computation of the
n_steps_defaultreturns a value smaller than 3 for very small filter factors (<= 1.8) together with a Gaussian filter shape. If the user does not specify their ownn_steps, the code will then setwhich then leads to an error when the mass matrix for the Galerkin basis is set up (which assumes
n_steps>=3).Changes
This PR simply makes sure that
n_steps_defaultis always at least 3 by settingn_steps_defaultas the maximum of our current computation and 3. There is also a new test, which would have failed with the previous implementation.