Skip to content

Conversation

@sendittothenewts
Copy link
Contributor

windows-sys is a frequent source of duplicate dependencies. Widening the range of allowed versions gives downstream crates a fighting chance of being able to select one unique version of it.

windows-sys is a frequent source of duplicate dependencies.  Widening the range
of allowed versions gives downstream crates a fighting chance of being able to
select one unique version of it.
@sendittothenewts
Copy link
Contributor Author

I have of course tested this. cargo test passes with both windows-sys 0.61.0 and 0.28.0 (and fails to compile on windows-sys 0.27).

@oconnor663
Copy link
Owner

oconnor663 commented Sep 9, 2025

I like this idea. Could you add some sort of test to .github/workflows/ci.yml to make sure we test this bound going forward? (Also I just pushed the bump to 0.61, so you'll need to rebase. Edit: I just did it here.)

@sendittothenewts
Copy link
Contributor Author

Ok, I've added the test, and it looks to be passing. I considered making that Windows-only, but then it occurred to me that testing the minimum libc crate might also be reasonable.

@sendittothenewts
Copy link
Contributor Author

sendittothenewts commented Oct 10, 2025

@oconnor663 Are you still interested in merging this? If so, a release including this pull some time in the next couple of weeks would be convenient.

@oconnor663
Copy link
Owner

Thanks for the reminder. I'll rebase this by hand and push a release.

@oconnor663
Copy link
Owner

Landed as 79256b3.

@oconnor663 oconnor663 closed this Oct 11, 2025
@oconnor663
Copy link
Owner

Released along with #38 as v1.2.3.

@sendittothenewts
Copy link
Contributor Author

Thanks! This has cleaned up my deps nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants