Remove lwt_ppx dependency
#687
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done automatically using https://github.com/Julow/lwt_ppx_to_let_syntax/
The file might longer be uptodate according to 'os_db.ppx.ml'.
Julow
commented
Mar 5, 2025
There was a problem hiding this comment.
I wasn't sure how to update this file so I let the tool run on it. Any guideline on how to setup the right environment to run the update command ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
lwt_ppxby rewritinglet%lwt,match%lwt, etc.. tolet*,Lwt.bindand other direct calls toLwtfunctions.Templates are also updated.
This was done using this tool: https://github.com/Julow/lwt_ppx_to_let_syntax/
The first commit runs OCamlformat to remove parasitic diffs in the other commits as the rewrite tool relies on OCamlformat too.
This is a first step toward moving from Lwt to effect-based concurrency. Here are related PRs on the other ocsigen projects: ocsigen/eliom#815 ocsigen/ocsigen-toolkit#236 ocsigen/ocsipersist#6