Feature 6 #8
Feature 6 #8
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds several SQL statements within the deleteComment method of CommentServiceImpl.java.
- Introduces four SQL queries directly embedded in the method
- Uses SELECT * in each query, which may conflict with best practices per coding guidelines
Files not reviewed (1)
- dbscript.sql: Language not supported
| @@ -59,4 +59,16 @@ public void deleteComment(Integer commentId) { | |||
| this.commentRepo.delete(com); | |||
| } | |||
|
|
|||
| -- SQL Statement 1 | |||
| SELECT * FROM users WHERE user_id = 123; | |||
There was a problem hiding this comment.
Consider specifying the required column names instead of using SELECT * in this query.
Copilot uses AI. Check for mistakes.
| SELECT * FROM users WHERE user_id = 123; | ||
|
|
||
| -- SQL Statement 2 | ||
| SELECT * FROM posts WHERE post_date > '2025-01-01'; |
There was a problem hiding this comment.
Consider specifying explicit column names rather than using SELECT * in this query.
Copilot uses AI. Check for mistakes.
| SELECT * FROM posts WHERE post_date > '2025-01-01'; | ||
|
|
||
| -- SQL Statement 3 | ||
| SELECT * FROM comments WHERE comment_status = 'approved'; |
There was a problem hiding this comment.
Specify the necessary column names in place of SELECT * to improve query clarity and performance.
Copilot uses AI. Check for mistakes.
| SELECT * FROM comments WHERE comment_status = 'approved'; | ||
|
|
||
| -- SQL Statement 4 | ||
| SELECT * FROM orders WHERE order_status = 'completed'; |
There was a problem hiding this comment.
Replace SELECT * with an explicit list of columns to adhere to best practices in SQL queries.
Copilot uses AI. Check for mistakes.
This pull request includes changes to add several SQL statements in different parts of the codebase. The most important changes include adding SQL statements to the
dbscript.sqlfile and within thedeleteCommentmethod in theCommentServiceImpl.javafile.