This repository was archived by the owner on Jun 20, 2022. It is now read-only.
[WIP] Implement event activity API #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to exapnd the URI
…the code for GenericService. Separated out URIs for the four search types
….com/octokit/go-octokit into service-refactoring-proof-of-concept
…okit/go-octokit into service-refactoring-proof-of-concept
Refactoring search service API to accept URI as parameter to service calls
Updates the Issues API to use the new pattern
Gists endpoint refactoring and expansion
|
@dhruvsinghal Looking good. I think if you cherry-pick 419bb92 or rebase over master, this will go 🍏. |
| client *Client | ||
| } | ||
|
|
||
| func (r *ActivityEventsService) One(uri *Hyperlink, params M) (event *Event, |
There was a problem hiding this comment.
@dhruvsinghal: Upon closer look, I don't think this service has a .One() use case does it?
|
I would love to play with the Event API, any ETA for merging this PR ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pengwynn Work in progress, but have a look to see if its going the way you want.