New implementation based on Webnative 0.35 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivash
reviewed
Dec 14, 2022
| @@ -1,220 +1,143 @@ | |||
| import * as auth from "webnative/auth/index.js" | |||
There was a problem hiding this comment.
so much red in this file(and the rest of the PR), i love it! 🙌🏼
3 tasks
Co-authored-by: Andrew Vivash <[email protected]> Signed-off-by: Steven Vandevelde <[email protected]>
avivash
reviewed
Dec 15, 2022
avivash
reviewed
Dec 15, 2022
icidasset
commented
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the Webnative integration from scratch. The result is a much smaller entry function and doesn't have the state problems like before.
The auth component has been replaced with crypto and manners components. Webnative signs UCANs using the crypto component's keystore functions, these connect to webnative-walletauth's wallet implementation. The manners component is used to store the root read-key encrypted on the user's file system and to retrieve + decrypt it as well. This is done by introducing file system hooks.
How to use, see README