form options #4183
Merged
form options #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
bso-odoo
force-pushed
the
master-mysterious-egg-bso-2
branch
12 times, most recently
from
f78f9dd to
c668828
Compare
FrancoisGe
reviewed
Mar 13, 2025
Comment on lines
216
to
217
| const messageEl = el.parentElement.querySelector(".s_website_form_end_message"); | ||
| return messageEl.classList.contains("o_builder_form_show_message"); |
There was a problem hiding this comment.
Undo => trigger error because messageEl is undefined. Maybe use applyTo("s_website_form_end_message") ?
There was a problem hiding this comment.
But t-if="isActiveItem('show_message_opt')".... why is this method even called when that condition is false ? (or maybe isActiveItem returns true while it should not.)
I can't use applyTo because I also need to apply the class on the form itself
bso-odoo
force-pushed
the
master-mysterious-egg-bso-2
branch
13 times, most recently
from
25111bb to
bb136ce
Compare
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
3ee87bf to
98b990a
Compare
bso-odoo
force-pushed
the
master-mysterious-egg-bso-2
branch
2 times, most recently
from
630ad1f to
ebffc34
Compare
bso-odoo
force-pushed
the
master-mysterious-egg-bso-2
branch
14 times, most recently
from
93e0b8c to
59466bc
Compare
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
f468b7f to
80b3d5d
Compare
bso-odoo
force-pushed
the
master-mysterious-egg-bso-2
branch
from
59466bc to
740ed44
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.