add BuilderList #4240
Open
add BuilderList #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
f468b7f to
80b3d5d
Compare
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
27a1402 to
8c6b756
Compare
agau-odoo
force-pushed
the
master-mysterious-egg-agau-4
branch
4 times, most recently
from
de09195 to
030f5d2
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
agau-odoo
force-pushed
the
master-mysterious-egg-agau-4
branch
from
030f5d2 to
e79686c
Compare
agau-odoo
force-pushed
the
master-mysterious-egg-agau-4
branch
from
e79686c to
27f2247
Compare
FrancoisGe
reviewed
Apr 3, 2025
Comment on lines
61
to
69
| validateProps() { | ||
| // entryShape types are supported | ||
| for (const [name, type] of Object.entries(this.props.entryShape)) { | ||
| if (!supportedEntryShapeTypes.includes(type)) { | ||
| throw new Error( | ||
| `BuilderList entryShape only supports ${supportedEntryShapeTypes.toString()} types, received ${name}: "${type}"` | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not use Component validation props ?
There was a problem hiding this comment.
(Maybe checkc ommunity/addons/html_editor/static/src/main/toolbar/toolbar.js)
There was a problem hiding this comment.
Thanks, I actually forgot to look into it. 😅 I fixed it in a 4th commit
Do you know if it's possible to validate a prop against other props?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.