MegaMenuOptions #4262
Open
MegaMenuOptions #4262
+325
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
robinlej
force-pushed
the
master-mysterious-egg-role-4
branch
2 times, most recently
from
6a36586 to
beb8130
Compare
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
27a1402 to
8c6b756
Compare
robinlej
force-pushed
the
master-mysterious-egg-role-4
branch
9 times, most recently
from
add2a19 to
0cb7457
Compare
robinlej
force-pushed
the
master-mysterious-egg-role-4
branch
from
0cb7457 to
282757c
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
robinlej
force-pushed
the
master-mysterious-egg-role-4
branch
from
282757c to
79443c4
Compare
FrancoisGe
reviewed
Apr 4, 2025
Comment on lines
+456
to
+457
| const hasClean = !!applySpec.clean; | ||
| const shouldClean = _shouldClean(comp, hasClean, isAlreadyApplied); |
There was a problem hiding this comment.
could you add a test for this change
| if (!this.getTemplateKey(key)) { | ||
| this.activeTemplateViews[key] = await this.services.orm.call( | ||
| "ir.ui.view", | ||
| "render_public_asset", |
There was a problem hiding this comment.
You can batch it like in webiteConfig :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.