[IMP] website_event, website_event_sale: adapt JsonLd builder

[gppa-odoo]

No description provided.

[robodoo]

This PR targets the un-managed branch odoo-dev/odoo:master-imp-website-schema-POC-design-gppa, it needs to be retargeted before it can be merged.

[gppa-odoo]

def _get_breadcrumb_items(self, is_detail_page=False):
from website_sale, use this instead

[divy-odoo]

you can direcly get the base url from self.get_base_url.

[divy-odoo]

Instead doing this, can't we simply prepare the breadcrumb in same method _get_breadcrumb_items?

Simply pass the same params, is_details_page to this mehtod,

    def _get_breadcrumb_items(self, is_detail_page): 
        """Return breadcrumb items for a single event page."""
        self.ensure_one()
        website = self.env['website'].get_current_website()
        base_url = website.get_base_url()
        breadcrumb_items =  [
            (website.name, base_url),
            (self.env._("Events"), f"{base_url}/event"),
            (self.name, f"{base_url}{self.website_url}"),
        ]
        if is_detail_page:
            breadcrumb_items.append( (self.name, f"{base_url}{self.website_url}"))

        return breadcrumb_items

Doing this, current method will be simplified to

    def _to_structured_data(self, is_detail_page=False):
        schemas = super()._to_structured_data(is_detail_page=is_detail_page)
        breadcrumb_items = self._get_breadcrumb_items(is_detail_page)
        schemas.append(self._get_breadcrumb_structured_data(items))
        if is_detail_page:
            self.ensure_one()
            if event_schema := self._to_structured_data_event():
                schemas.append(event_schema)
        else:
            schemas.append(self._to_structured_data_collectionpage())
        return JsonLd.render_structured_data(schemas)
        

[divy-odoo]

Suggested change

	if image_url := website.image_url(self, 'image_1920'):
	if image_url := self.website_id.image_url(self, 'image_1920'):

?

[divy-odoo]

Suggested change

	base_url = self.env['website'].get_current_website().get_base_url()
	base_url = self.get_base_url()

[divy-odoo]

Suggested change

	event_data = self._to_structured_data_summary_event()
	event_jsonld = self._to_structured_data_summary_event()

[divy-odoo]

Suggested change

	if organizer_sudo == self.env.company.partner_id:
	base_url = self.env['website'].get_current_website().get_base_url()
	nested_schema_data["organizer"] = JsonLd("Organization", {"@id": f"{base_url}/#organization"})
	else:
	organizer_jsonld = JsonLd("Organization", {"name": organizer_sudo.name})
	if organizer_sudo.website:
	organizer_jsonld.set({"url": organizer_sudo.website})
	nested_schema_data["organizer"] = organizer_jsonld
	organizer_data = {}
	if organizer_sudo == self.env.company.partner_id:
	organizer_data["@id"] = f"{self.get_base_url()}/#organization"
	else:
	organizer_data["name"] = organizer_sudo.name
	if organizer_sudo.website:
	organizer_data["name"] = organizer_sudo.website
	nested_schema_data["organizer"] = JsonLd("Organization", organizer_data)

or

Suggested change

	if organizer_sudo == self.env.company.partner_id:
	base_url = self.env['website'].get_current_website().get_base_url()
	nested_schema_data["organizer"] = JsonLd("Organization", {"@id": f"{base_url}/#organization"})
	else:
	organizer_jsonld = JsonLd("Organization", {"name": organizer_sudo.name})
	if organizer_sudo.website:
	organizer_jsonld.set({"url": organizer_sudo.website})
	nested_schema_data["organizer"] = organizer_jsonld
	organizer_data = {}
	if organizer_sudo == self.env.company.partner_id:
	organizer_data["@id"] = f"{self.get_base_url()}/#organization"
	else:
	organizer_data = {
	"name": organizer_sudo.name,
	"url": organizer_sudo.website
	}
	nested_schema_data["organizer"] = JsonLd("Organization", organizer_data)

[divy-odoo]

Suggested change

	if description is not None:
	if description:

[divy-odoo]

Suggested change

	offers_jsonld = [self._to_structured_data_ticket_offer(ticket) for ticket in self.event_ticket_ids]
	offers_jsonlds = self._to_structured_data_ticket_offer()

You can move this loop inside the offers.

def _to_structured_data_ticket_offer(self, ticket):
    # builds ONE offer
    ...

def _to_structured_data_ticket_offers(self):
    return [
        self._to_structured_data_ticket_offer(ticket)
        for ticket in self.event_ticket_ids
    ]

[gppa-odoo]

/addons/website_event_sale/models/event_event.py

We are using this inside this file, It is lot more easier to extend when it's not returning a list.

[divy-odoo]

It is still not returning a list, you can always extend _to_structured_data_ticket_offer.

[divy-odoo]

Instead this I would prefer to create a variable name is_available

is_available = not (ticket.is_sold_out or is_expired)

[divy-odoo]

Suggested change

	"""Return breadcrumb items for a single event page.
	"""Return breadcrumb items for a event page.

[divy-odoo]

Suggested change

	breadcrumb = self._build_breadcrumb_schema(
	breadcrumb_jsonld = self._build_breadcrumb_schema(

[divy-odoo]

isn;'t event_schema holds the jsonld? It's becoming confusing when sometime you refer it as schema & sometime as *_jsonld.

• we can refer the main schema as schema & rest *_jsonld. like here, schemas will be same ( collection of all the schemas) & rest will become *_jsonld, like event_jsonld.

[divy-odoo]

Suggested change

	website = self.env['website'].get_current_website()
	if website.show_line_subtotals_tax_selection == 'tax_excluded':
	if self.website_id.show_line_subtotals_tax_selection == 'tax_excluded':

use website_id , wherever available.