[IMP] test_themes: whitelist carousel snippet classes in themes test - #1199
Open
rusp-odoo wants to merge 1 commit into
Open
[IMP] test_themes: whitelist carousel snippet classes in themes test#1199rusp-odoo wants to merge 1 commit into
rusp-odoo wants to merge 1 commit into
Conversation
Collaborator
|
|
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
3 times, most recently
from
December 16, 2025 08:38
aec77bd to
996874f
Compare
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
from
December 18, 2025 09:37
996874f to
581335f
Compare
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
2 times, most recently
from
January 1, 2026 08:58
aa7444f to
4ecd213
Compare
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
from
January 12, 2026 06:37
4ecd213 to
9ccd018
Compare
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
from
January 27, 2026 11:58
9ccd018 to
2d38abc
Compare
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
2 times, most recently
from
March 2, 2026 09:42
ba17ea8 to
19dc4be
Compare
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
4 times, most recently
from
March 20, 2026 06:38
d2fabd6 to
977a97b
Compare
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
5 times, most recently
from
April 2, 2026 06:19
c415f8a to
c546da9
Compare
rusp-odoo
changed the title
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
3 times, most recently
from
April 3, 2026 07:38
9959a97 to
a6fddfc
Compare
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
5 times, most recently
from
April 29, 2026 12:08
5379bc2 to
08caed6
Compare
rusp-odoo
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
4 times, most recently
from
May 15, 2026 05:15
e26976e to
39c94d0
Compare
aans-odoo
approved these changes
May 18, 2026
rusp-odoo
marked this pull request as ready for review
May 18, 2026 05:44
rushil-b-patel
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
4 times, most recently
from
June 11, 2026 05:24
af31d9c to
2f53dd7
Compare
rushil-b-patel
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
from
July 1, 2026 11:27
2f53dd7 to
fd5eb7d
Compare
rushil-b-patel
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
4 times, most recently
from
August 24, 2026 12:13
8f98e57 to
bada545
Compare
The new blog posts, events, and appointments carousel snippets introduce layout classes that are not anchored to a data-snippet attribute. The themes test flags these as unexpected, so they must be explicitly whitelisted to prevent false test failures. task-5090459
rushil-b-patel
force-pushed
the
master-imp-website-dynamic-carousels-rusp
branch
from
August 25, 2026 11:16
bada545 to
c210674
Compare
loco-odoo
suggested changes
Aug 27, 2026
Comment on lines
+117
to
+119
| 's_carousel_indicators_hidden', 's_blog_posts_carousel', 's_events_carousel', | ||
| 's_dynamic', 's_blog_posts_post', 's_blog_posts_effect_marley', | ||
| 's_blog_posts_post_picture_size_default', 's_appointments_carousel', 's_events_event', |
Contributor
There was a problem hiding this comment.
This actually indicates that few of the classes you used in your new snippets do not correctly follow the convention. I let you check the test_render_applied_templates test but let's take the example of s_blog_posts_post: if you drop your new blog carousel on the page, there are s_blog_posts_post elements that do not have a .s_blog_posts ancestor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new blog posts, events, and appointments carousel snippets introduce
layout classes that are not anchored to a data-snippet attribute. The
themes test flags these as unexpected, so they must be explicitly
whitelisted to prevent false test failures.
Community PR - odoo/odoo#238099
Enterprise PR - https://github.com/odoo/enterprise/pull/101478
task-5090459