Skip to content

[IMP] accounting/l10n_co: DIAN Demo Mode Environment #13337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

masi-odoo
Copy link
Contributor

Add documentation on the DIAN Demo Mode Environment, used for initial demos/first tests with a demo digital certificate and no sending to the DIAN environments for validation.

Related task - 4087930

@robodoo
Copy link
Collaborator

robodoo commented May 12, 2025

Pull request status dashboard

@@ -149,6 +149,10 @@ scroll to the :guilabel:`Colombian Electronic Invoicing` section. Then, follow t
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers three different
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samueljlieber what do you recommend to rephrase this, as still we will be offering 3 different environments to connect to the DIAN but also a fourth one (DIAN Demo Mode) that does not have connection with the DIAN and its more of an internal testing mode.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fair to say four environments, detailing each below, since this new DIAN Demo Mode is part of the Electronic invoicing for Colombia with DIAN (l10n_co_dian) module :)

Suggested change
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers three different
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers four different
|DIAN| environments to connect with:

@samueljlieber samueljlieber self-assigned this May 13, 2025
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @masi-odoo! This PR looks good to me, approving with the following changes that I will push up after this review! :)

@@ -149,6 +149,10 @@ scroll to the :guilabel:`Colombian Electronic Invoicing` section. Then, follow t
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers three different
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fair to say four environments, detailing each below, since this new DIAN Demo Mode is part of the Electronic invoicing for Colombia with DIAN (l10n_co_dian) module :)

Suggested change
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers three different
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers four different
|DIAN| environments to connect with:

Add documentation on the DIAN Demo Mode Environment, used for initial demos/first tests with a demo digital certificate and no sending to the DIAN environments for validation.

Related task - 4087930
@samueljlieber samueljlieber changed the base branch from 18.0 to master May 13, 2025 18:50
@samueljlieber samueljlieber changed the base branch from master to 18.0 May 13, 2025 18:50
@samueljlieber samueljlieber changed the title [ADD] accounting/l10n_co: DIAN Demo Mode Environment [IMP] accounting/l10n_co: DIAN Demo Mode Environment May 13, 2025
@C3POdoo C3POdoo requested a review from a team May 13, 2025 18:51
@masi-odoo
Copy link
Contributor Author

Awesome, thanks for the improvements @samueljlieber !

@afma-odoo afma-odoo requested review from afma-odoo and removed request for a team May 15, 2025 08:44
Copy link
Contributor

@afma-odoo afma-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samueljlieber @masi-odoo for the update on this page!
It looks great to me, I approve it and add the be-doc-review ;)

Thank you ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants