-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[IMP] accounting/l10n_co: DIAN Demo Mode Environment #13337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
@@ -149,6 +149,10 @@ scroll to the :guilabel:`Colombian Electronic Invoicing` section. Then, follow t | |||
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers three different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samueljlieber what do you recommend to rephrase this, as still we will be offering 3 different environments to connect to the DIAN but also a fourth one (DIAN Demo Mode) that does not have connection with the DIAN and its more of an internal testing mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fair to say four environments, detailing each below, since this new DIAN Demo Mode is part of the Electronic invoicing for Colombia with DIAN (l10n_co_dian
) module :)
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers three different | |
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers four different | |
|DIAN| environments to connect with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @masi-odoo! This PR looks good to me, approving with the following changes that I will push up after this review! :)
@@ -149,6 +149,10 @@ scroll to the :guilabel:`Colombian Electronic Invoicing` section. Then, follow t | |||
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers three different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fair to say four environments, detailing each below, since this new DIAN Demo Mode is part of the Electronic invoicing for Colombia with DIAN (l10n_co_dian
) module :)
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers three different | |
#. Configure the |DIAN| environment; the |DIAN| electronic invoicing module offers four different | |
|DIAN| environments to connect with: |
Add documentation on the DIAN Demo Mode Environment, used for initial demos/first tests with a demo digital certificate and no sending to the DIAN environments for validation. Related task - 4087930
a5c99c7
to
f0e8f8b
Compare
Awesome, thanks for the improvements @samueljlieber ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @samueljlieber @masi-odoo for the update on this page!
It looks great to me, I approve it and add the be-doc-review ;)
Thank you
Add documentation on the
DIAN Demo Mode Environment
, used for initial demos/first tests with a demo digital certificate and no sending to the DIAN environments for validation.Related task - 4087930