Skip to content

[ADD] barcode: operations and commands barcode printing #13355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

slinkous
Copy link
Contributor

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented May 13, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team May 13, 2025 00:55
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far, @slinkous ! 😊 The doc is really in-depth and it's going to be SO helpful! 😍

I know you haven't requested a review from me, yet! I just did a quick scan 👀 😉 to catch some quick formatting and style things. I presumed that since you pushed this PR up at the end of the day, you'll still have it open when you come in tomorrow, so it'll be easy to do some fixes before you move onto another task 😊

Comment on lines +34 to +35
The :guilabel:`Internal Transfers (WHINT)` operation barcode is available if the database is using
the ::guilabel:`Storage Locations` to designate where products are located in the inventory. To
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nitpicky but we only use the guilabel tag when that field is currently visible on the UI. In this intro sentence, we haven't navigated to a specific page yet, so it's not yet on the reader's page. So, we use italics 😊

Suggested change
The :guilabel:`Internal Transfers (WHINT)` operation barcode is available if the database is using
the ::guilabel:`Storage Locations` to designate where products are located in the inventory. To
The *Internal Transfers (WHINT)* operation barcode is available if the database is using
the *Storage Locations* to designate where products are located in the warehouse. To

Note: extra : in front of storage locations, and maybe missing the word "feature"?

optional: I'm not really sure if "products are located in the inventory" is a common phrase? How about "in the warehouse", or "in inventory" (without "the")?

The :guilabel:`Internal Transfers (WHINT)` operation barcode is available if the database is using
the ::guilabel:`Storage Locations` to designate where products are located in the inventory. To
enable this setting, go to :menuselection:`Inventory app --> Configuration --> Settings`, then, in
the :guilabel:`Warehouse` section, tick the :guilabel:`Storage Locations` option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guilabels properly used here! 😊

============================

Inventory operations, like :doc:`receipts and delivery
orders<../../inventory/shipping_receiving/daily_operations/receipts_delivery_one_step>`, as well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
orders<../../inventory/shipping_receiving/daily_operations/receipts_delivery_one_step>`, as well
orders <../../inventory/shipping_receiving/daily_operations/receipts_delivery_one_step>`, as well

we need one space between link text and link (:


*Operation types* in the **Inventory** and **Barcode** apps define actions that will change the
state of products in inventory. What operation types are available will depend on the settings which
are enabled in the database. By default, barcodes can be printed for the :guilabel:`Receipts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
are enabled in the database. By default, barcodes can be printed for the :guilabel:`Receipts
are enabled in the database. By default, barcodes can be printed for :guilabel:`Receipts

maybe an extra "the"? Also see my later comment about possibly changing these guilabels to italics if the operation types aren't visible on the screen (:


.. note::
Both :guilabel:`Internal Transfers (WHINT)` and :guilabel:`Pick (WHPICK)` operations require
:doc:`location barcodes <./software>` to scan.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:doc:`location barcodes <./software>` to scan.
:doc:`location barcodes <../software>` to scan.

<../../inventory/shipping_receiving/daily_operations/receipts_delivery_two_steps>`
- :doc:`Three-step delivery
<../../inventory/shipping_receiving/daily_operations/delivery_three_steps>`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

extra line

.. warning::
Printing barcodes, by default, will either directly download a PDF file of the selected barcodes
or open a new tab with a downloadable or printable PDF. To turn this into a direct printing
operation, :doc:`connect a printer<../../../general/iot/devices/printer>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
operation, :doc:`connect a printer<../../../general/iot/devices/printer>`.
operation, :doc:`connect a printer <../../../general/iot/devices/printer>`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants