[IMP] accounting: vendor bill digitization & update PO matching #14332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@afma-odoo @auva-odoo cherrypicking of pull request #13928 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
task-4865418 task-4844221 X-original-commit: ddd957d
afma-odoo
force-pushed
the
18.0-17.0-accounting-vendorbills-digitization-ocr-afma-447998-fw
branch
from
c92ff63 to
5762871
Compare
|
@afma-odoo @auva-odoo this forward port of #13928 is awaiting action (not merged or closed). |
auva-odoo
requested changes
Aug 26, 2025
Comment on lines
+96
to
+97
| To set an auto-post bills option for a vendor, go to :menuselection:`Accounting --> Vendors --> | ||
| Vendors`. In the :guilabel:`Accounting` tab of the contact form, select an :guilabel:`Auto-post |
There was a problem hiding this comment.
Suggested change
| To set an auto-post bills option for a vendor, go to :menuselection:`Accounting --> Vendors --> | |
| Vendors`. In the :guilabel:`Accounting` tab of the contact form, select an :guilabel:`Auto-post | |
| To set an auto-post bills option for a vendor, go to :menuselection:`Accounting --> Vendors --> | |
| Vendors` and click the desired vendor. In the :guilabel:`Accounting` tab of the contact form, select an :guilabel:`Auto-post |
Comment on lines
+107
to
+113
| .. tip:: | ||
| The following conditions must be met for bills to be auto-posted: | ||
|
|
||
| - The :guilabel:`Digitize automatically` option in the :guilabel:`Document Digitization` section | ||
| must be enabled for vendor bills. | ||
| - Since automation is triggered after three validated bills without edits, the contact name must | ||
| already exist in the database, and each uploaded vendor bill must include a bill date. |
There was a problem hiding this comment.
Since these are pre-requisites for the feature, I wouldn't have them in a tip:
- I would move the first list item before the part where you explain how to enable the feature for a vendor. i'd also add a ref to the Configuration section of this doc page.
- I think the second list item can be in a note and can stay here.
- Then I don't think the introductory sentence on line 108 would be needed anymore.
|
|
||
| .. _accounting/bill-digitization/vendor-bills-matching-po: | ||
|
|
||
| Purchase matching |
There was a problem hiding this comment.
I'm curious to know why you decided to change this heading (compared to the 17.0 version)? I think I would at least write "Purchase order matching" here instead, what do you think?
| <accounting/bill-digitization/vendor-bills-upload>`, click :guilabel:`Digitize document`. | ||
|
|
||
| Once the document has been digitized, a blue banner appears; click :icon:`oi-arrow-right` | ||
| :guilabel:`Refresh` if needed. Review and correct any information uploaded during digitization: |
There was a problem hiding this comment.
Suggested change
| :guilabel:`Refresh` if needed. Review and correct any information uploaded during digitization: | |
| :guilabel:`Refresh`. Review and correct any information uploaded during digitization: |
Comment on lines
+163
to
+164
| purchase orders linked to the corresponding vendor. Then, select the relevant lines from the | ||
| purchase order and the draft vendor bill (shown in grey), and click :guilabel:`Match`. |
There was a problem hiding this comment.
Suggested change
| purchase orders linked to the corresponding vendor. Then, select the relevant lines from the | |
| purchase order and the draft vendor bill (shown in grey), and click :guilabel:`Match`. | |
| purchase order lines linked to the vendor defined for the vendor bill. Then, select the relevant purchase order lines and the draft vendor bill (shown in grey), and click :guilabel:`Match`. |
- since you see the PO lines in this view
- to make it clearer
- (defined not great; feel free to improve this)
Comment on lines
+186
to
+187
| Close` in the :guilabel:`Create Purchase Order` window. Then, open the Purchase app to fill in | ||
| the fields and confirm the purchase order. |
There was a problem hiding this comment.
Should we add a doc link for the Purchase app, just for good measure?
| In the :guilabel:`Purchase Matching` list view, update the :guilabel:`Quantity` and | ||
| :guilabel:`Price` in the purchase order lines, if necessary. | ||
|
|
||
| If there is no existing purchase order related to the uploaded vendor bill, a new purchase order |
There was a problem hiding this comment.
Suggested change
| If there is no existing purchase order related to the uploaded vendor bill, a new purchase order | |
| If there is no existing purchase order related to the vendor of the uploaded vendor bill, a new purchase order |
| If there is no existing purchase order related to the uploaded vendor bill, a new purchase order | ||
| can be directly created from the vendor bill lines. To do so, follow these steps: | ||
|
|
||
| #. Once the vendor bill is uploaded, make sure the :guilabel:`Vendor` field is filled in. |
There was a problem hiding this comment.
Suggested change
| #. Once the vendor bill is uploaded, make sure the :guilabel:`Vendor` field is filled in. | |
| #. Once the vendor bill is uploaded, make sure the :guilabel:`Vendor` field is filled in with the correct vendor. |
(to be improved)
Comment on lines
+178
to
+179
| #. In the :guilabel:`Create Purchase Order` window, complete all :ref:`required fields | ||
| <purchase/manage_deals/create-new-rfq>` in the purchase order form and click :guilabel:`Confirm |
There was a problem hiding this comment.
Suggested change
| #. In the :guilabel:`Create Purchase Order` window, complete all :ref:`required fields | |
| <purchase/manage_deals/create-new-rfq>` in the purchase order form and click :guilabel:`Confirm | |
| #. In the :guilabel:`Create Purchase Order` window, select the vendor from the bill, then complete all :ref:`required fields <purchase/manage_deals/create-new-rfq>` and click :guilabel:`Confirm |
(feel free to improve this! I removed purchase order form since you said "in the Create purchase order window" at the beginning of the sentence)
Comment on lines
+181
to
+182
| #. In the :guilabel:`Purchase Matching` list view, select the relevant lines from the purchase order | ||
| and the lines from the draft vendor bill (shown in grey), and click :guilabel:`Match`. |
There was a problem hiding this comment.
Suggested change
| #. In the :guilabel:`Purchase Matching` list view, select the relevant lines from the purchase order | |
| and the lines from the draft vendor bill (shown in grey), and click :guilabel:`Match`. | |
| #. In the :guilabel:`Purchase Matching` list view, select the relevant purchase order lines and the draft vendor bill (shown in grey), and click :guilabel:`Match`. |
since there's only one line for the vendor bill?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-4865418
task-4844221
Forward-Port-Of: #13928