[IMP] bike_shop: improve design of demo website - #2753
Open
eswa-odoo wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
bram-odoo
requested changes
Aug 10, 2026
bram-odoo
left a comment
bram-odoo
left a comment
Contributor
There was a problem hiding this comment.
Hey @eswa-odoo, here is my review :-) Congratulations for this top-notch gems!
Contributor
|
I forgot something: Is it normal that the ressource is shown (as it can't be modified by the end-user) or is it just because I'm logged in as an administrator? |
eswa-odoo
force-pushed
the
saas-19.4-bike_shop-website-eswa
branch
2 times, most recently
from
August 20, 2026 06:27
469d2a1 to
f9c8f0b
Compare
bram-odoo
approved these changes
Aug 20, 2026
bram-odoo
reviewed
Aug 20, 2026
bram-odoo
reviewed
Aug 20, 2026
tocodoo
force-pushed
the
saas-19.4-bike_shop-website-eswa
branch
from
August 20, 2026 11:24
4927e45 to
229cf81
Compare
This commit adds a demo website into the `/bike_shop` industry module. When the user installs the industry with demo data, it creates a second website with a cutting edge look and feel to demonstrate what users can achieve with the Website Builder. task-5477795
tocodoo
force-pushed
the
saas-19.4-bike_shop-website-eswa
branch
from
August 20, 2026 11:25
229cf81 to
9409ba9
Compare
bram-odoo
marked this pull request as ready for review
August 21, 2026 14:00
vava-odoo
reviewed
Aug 28, 2026
vava-odoo
left a comment
vava-odoo
left a comment
Collaborator
There was a problem hiding this comment.
Not much to say, nicely done
have a look at the warning here https://runbot.odoo.com/runbot/build/123243883
- following comments
| <!-- `data/qweb_views.xml` binds this form to `base.default_website`, which still | ||
| points to Odoo's own website when the data files are loaded. Rebind it to the | ||
| demo website created above. --> | ||
| <record id="team_form_2" model="ir.ui.view"> |
Collaborator
There was a problem hiding this comment.
shouldn't it be duplicated instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a demo website into the
/bike_shopindustry module. When the user installs the industry with demo data, it creates a second website with a cutting edge look and feel to demonstrate what users can achieve with the Website Builder.task-5477795